Skip to content

Remove pipeline-scoped Publish-Build-Assets group - #19518

Merged
Adam Ratzman (adamint) merged 4 commits into
microsoft:mainfrom
adamint:adamint-port-pr-63710
Aug 20, 2026
Merged

Remove pipeline-scoped Publish-Build-Assets group#19518
Adam Ratzman (adamint) merged 4 commits into
microsoft:mainfrom
adamint:adamint-port-pr-63710

Conversation

@adamint

@adamint Adam Ratzman (adamint) commented Aug 20, 2026

Copy link
Copy Markdown
Member

Description

Ports internal PR 63710 to main.

This removes the pipeline-scoped Publish-Build-Assets variable group. Asset_Registry_Publish already loads the group at job scope, so the credentials remain available where they are needed without being injected into every pipeline stage.

The internal npm mirror currently serves @azure/identity 4.13.2 without its quarantined @azure/core-process dependency. This also pins Azure Identity 4.13.1 explicitly at all four VSCE install sites so their transitive dependency graph remains stable across npm feed updates.

Build 3052356 completed every stage and job with no failed or canceled records. Its warning-only partiallySucceeded result matches the recent main control build. The final commit only clarifies comments and does not change the validated pipeline behavior.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Adam Ratzman (adamint) and others added 3 commits August 19, 2026 15:13
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: dbe46f58-0f31-4540-a647-0d0e77bea4f1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: dbe46f58-0f31-4540-a647-0d0e77bea4f1
Copilot AI balanced review requested due to automatic review settings August 20, 2026 00:24
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19518

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19518"

@github-actions github-actions Bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes pipeline-wide BAR publishing credentials while preserving job-scoped access, and pins Azure Identity to avoid an unavailable mirrored dependency.

Changes:

  • Removes Publish-Build-Assets from common pipeline variables.
  • Documents job-scoped BAR credentials and branch gating.
  • Pins @azure/identity 4.13.1 across all VSCE installations.
Show a summary per file
File Description
eng/pipelines/common-variables.yml Removes the pipeline-scoped variable group.
eng/pipelines/azure-pipelines.yml Clarifies job-scoped credential loading.
eng/pipelines/templates/build_extension.yml Pins Azure Identity for extension builds.
eng/pipelines/azure-pipelines-unofficial.yml Pins Azure Identity in unofficial builds.
eng/pipelines/azure-pipelines-codeql.yml Pins Azure Identity in CodeQL builds.
eng/pipelines/release-publish-nuget.yml Pins Azure Identity for marketplace publishing.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: dbe46f58-0f31-4540-a647-0d0e77bea4f1
Copilot AI review requested due to automatic review settings August 20, 2026 01:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 6/6 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@adamint
Adam Ratzman (adamint) merged commit b5be9fc into microsoft:main Aug 20, 2026
9 checks passed
@adamint

Copy link
Copy Markdown
Member Author

/backport to release/13.5

@github-actions github-actions Bot added this to the 13.6 milestone Aug 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/13.5 (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants