Remove pipeline-scoped Publish-Build-Assets group - #19518
Merged
Adam Ratzman (adamint) merged 4 commits intoAug 20, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dbe46f58-0f31-4540-a647-0d0e77bea4f1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dbe46f58-0f31-4540-a647-0d0e77bea4f1
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19518Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19518" |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes pipeline-wide BAR publishing credentials while preserving job-scoped access, and pins Azure Identity to avoid an unavailable mirrored dependency.
Changes:
- Removes
Publish-Build-Assetsfrom common pipeline variables. - Documents job-scoped BAR credentials and branch gating.
- Pins
@azure/identity4.13.1 across all VSCE installations.
Show a summary per file
| File | Description |
|---|---|
eng/pipelines/common-variables.yml |
Removes the pipeline-scoped variable group. |
eng/pipelines/azure-pipelines.yml |
Clarifies job-scoped credential loading. |
eng/pipelines/templates/build_extension.yml |
Pins Azure Identity for extension builds. |
eng/pipelines/azure-pipelines-unofficial.yml |
Pins Azure Identity in unofficial builds. |
eng/pipelines/azure-pipelines-codeql.yml |
Pins Azure Identity in CodeQL builds. |
eng/pipelines/release-publish-nuget.yml |
Pins Azure Identity for marketplace publishing. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dbe46f58-0f31-4540-a647-0d0e77bea4f1
David Negstad (danegsta)
approved these changes
Aug 20, 2026
Member
Author
|
/backport to release/13.5 |
Contributor
|
Started backporting to |
1 task
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports internal PR 63710 to
main.This removes the pipeline-scoped
Publish-Build-Assetsvariable group.Asset_Registry_Publishalready loads the group at job scope, so the credentials remain available where they are needed without being injected into every pipeline stage.The internal npm mirror currently serves
@azure/identity4.13.2 without its quarantined@azure/core-processdependency. This also pins Azure Identity 4.13.1 explicitly at all four VSCE install sites so their transitive dependency graph remains stable across npm feed updates.Build 3052356 completed every stage and job with no failed or canceled records. Its warning-only
partiallySucceededresult matches the recentmaincontrol build. The final commit only clarifies comments and does not change the validated pipeline behavior.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?