[release/13.5] Respect project server ready action overrides - #19451
Closed
aspire-repo-bot[bot] wants to merge 1 commit into
Closed
[release/13.5] Respect project server ready action overrides#19451aspire-repo-bot[bot] wants to merge 1 commit into
aspire-repo-bot[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
aspire-repo-bot
Bot
requested review from
Adam Ratzman (adamint) and
Ella Hathaway (ellahathaway)
as code owners
August 17, 2026 23:22
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
This PR updates the .NET project debugger extension to preserve an explicitly configured serverReadyAction (instead of overriding it from launchSettings.json) and adds a regression test to validate that behavior.
Changes:
- Only derive
serverReadyActionfromlaunchSettings.jsonwhen one is not already provided via debugger settings. - Add a test ensuring a project debugger’s
serverReadyActionis preserved. - Broaden
DebugLaunchSettingstyping to allow additional/unknown keys.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| extension/src/test/dotnetDebugger.test.ts | Adds a regression test to ensure serverReadyAction from debugger settings is not overridden. |
| extension/src/debugger/languages/dotnet.ts | Adjusts logic to only set serverReadyAction from launch settings when not already set. |
| extension/src/dcp/types.ts | Allows extra keys on DebugLaunchSettings via an index signature. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1750
to
+1800
| const projectDir = path.join(tempDir, 'WebProject'); | ||
| const propertiesDir = path.join(projectDir, 'Properties'); | ||
| fs.mkdirSync(propertiesDir, { recursive: true }); | ||
|
|
||
| const projectPath = path.join(projectDir, 'WebProject.csproj'); | ||
| fs.writeFileSync(projectPath, '<Project></Project>'); | ||
| fs.writeFileSync(path.join(propertiesDir, 'launchSettings.json'), JSON.stringify({ | ||
| profiles: { | ||
| Development: { | ||
| commandName: 'Project', | ||
| launchBrowser: true, | ||
| applicationUrl: 'https://localhost:5001' | ||
| } | ||
| } | ||
| }, null, 2)); | ||
|
|
||
| const outputPath = path.join(projectDir, 'bin', 'Debug', 'net7.0', 'WebProject.dll'); | ||
| const { extension } = createDebuggerExtension(outputPath, null, true, true); | ||
| const launchConfig: ProjectLaunchConfiguration = { | ||
| type: 'project', | ||
| project_path: projectPath, | ||
| launch_profile: 'Development' | ||
| }; | ||
| const serverReadyAction = { | ||
| action: 'openIntegratedBrowser', | ||
| pattern: 'Now listening on:\\s+\\[?(https?://[^\\]\\s]+)' | ||
| }; | ||
| const debugSessionConfig: AspireExtendedDebugConfiguration = { | ||
| type: 'aspire', | ||
| request: 'launch', | ||
| name: 'Aspire', | ||
| program: projectPath, | ||
| debuggers: { | ||
| project: { | ||
| serverReadyAction | ||
| } | ||
| } | ||
| }; | ||
| const fakeAspireDebugSession = sinon.createStubInstance(AspireDebugSession); | ||
|
|
||
| const debugConfig = await createDebugSessionConfiguration( | ||
| debugSessionConfig, | ||
| launchConfig, | ||
| undefined, | ||
| [], | ||
| { debug: true, runId: '1', debugSessionId: '1', isApphost: false, debugSession: fakeAspireDebugSession }, | ||
| extension); | ||
|
|
||
| assert.deepStrictEqual(debugConfig.serverReadyAction, serverReadyAction); | ||
|
|
||
| fs.rmSync(tempDir, { recursive: true, force: true }); |
Comment on lines
+1750
to
+1800
| const projectDir = path.join(tempDir, 'WebProject'); | ||
| const propertiesDir = path.join(projectDir, 'Properties'); | ||
| fs.mkdirSync(propertiesDir, { recursive: true }); | ||
|
|
||
| const projectPath = path.join(projectDir, 'WebProject.csproj'); | ||
| fs.writeFileSync(projectPath, '<Project></Project>'); | ||
| fs.writeFileSync(path.join(propertiesDir, 'launchSettings.json'), JSON.stringify({ | ||
| profiles: { | ||
| Development: { | ||
| commandName: 'Project', | ||
| launchBrowser: true, | ||
| applicationUrl: 'https://localhost:5001' | ||
| } | ||
| } | ||
| }, null, 2)); | ||
|
|
||
| const outputPath = path.join(projectDir, 'bin', 'Debug', 'net7.0', 'WebProject.dll'); | ||
| const { extension } = createDebuggerExtension(outputPath, null, true, true); | ||
| const launchConfig: ProjectLaunchConfiguration = { | ||
| type: 'project', | ||
| project_path: projectPath, | ||
| launch_profile: 'Development' | ||
| }; | ||
| const serverReadyAction = { | ||
| action: 'openIntegratedBrowser', | ||
| pattern: 'Now listening on:\\s+\\[?(https?://[^\\]\\s]+)' | ||
| }; | ||
| const debugSessionConfig: AspireExtendedDebugConfiguration = { | ||
| type: 'aspire', | ||
| request: 'launch', | ||
| name: 'Aspire', | ||
| program: projectPath, | ||
| debuggers: { | ||
| project: { | ||
| serverReadyAction | ||
| } | ||
| } | ||
| }; | ||
| const fakeAspireDebugSession = sinon.createStubInstance(AspireDebugSession); | ||
|
|
||
| const debugConfig = await createDebugSessionConfiguration( | ||
| debugSessionConfig, | ||
| launchConfig, | ||
| undefined, | ||
| [], | ||
| { debug: true, runId: '1', debugSessionId: '1', isApphost: false, debugSession: fakeAspireDebugSession }, | ||
| extension); | ||
|
|
||
| assert.deepStrictEqual(debugConfig.serverReadyAction, serverReadyAction); | ||
|
|
||
| fs.rmSync(tempDir, { recursive: true, force: true }); |
| } | ||
|
|
||
| export interface DebugLaunchSettings { | ||
| [key: string]: unknown; |
Ella Hathaway (ellahathaway)
approved these changes
Aug 17, 2026
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19451Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19451" |
Contributor
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 0 / 100 test projects · 2 jobs, from 3 changed files. Selected test projects (0 / 100)none — no .NET test projects run for this change. Selected jobs (2)
How these were chosen — grouped by what changedJob reasons
Selection computed for commit |
Jose Perez Rodriguez (joperezr)
approved these changes
Aug 17, 2026
Jose Perez Rodriguez (joperezr)
left a comment
Jose Perez Rodriguez (joperezr)
left a comment
Member
There was a problem hiding this comment.
Customer reported, scoped to the extension, low risk. APproved.
Member
|
We are not releasing extension off of this release branch. There are no CLI or other package changes, so we should not backport. going to close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #19200 to release/13.5
/cc Ella Hathaway (@ellahathaway)
Customer Impact
Testing
Risk
Regression?