Skip to content

Remove unnecessary code from AppHost in Orleans playground #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidfowl merged 2 commits into from
Jan 27, 2024
Merged

Remove unnecessary code from AppHost in Orleans playground #1904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1b7e92
remove unnecessary code from Orleans AppHost
VincentH-Net Jan 27, 2024
2782887
format comment in Orleans AppHost
VincentH-Net Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions playground/orleans/OrleansAppHost/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,19 @@
var builder = DistributedApplication.CreateBuilder(args);

var storage = builder.AddAzureStorage("storage");

if (!args.Contains("--publisher")) // AZD UP passes in --publisher manifest
{
storage.UseEmulator();
}
else
{
builder.AddAzureProvisioning();
}

var storage = builder.AddAzureStorage("storage").UseEmulator();
var clusteringTable = storage.AddTables("clustering");
var grainStorage = storage.AddBlobs("grainstate");

var orleans = builder.AddOrleans("my-app")
.WithClustering(clusteringTable)
.WithGrainStorage("Default", grainStorage);

// For local development, instead of using the emulator,
// one can use the in memory provider from Orleans:
// For local development (see https://github.com/dotnet/aspire/issues/1823 for how to detect),
// instead of using the emulator, one can use the in memory provider from Orleans:
//
//var orleans = builder.AddOrleans("my-app")
// .WithDevelopmentClustering()
// .WithMemoryGrainStorage("Default");
// var orleans = builder.AddOrleans("my-app")
// .WithDevelopmentClustering()
// .WithMemoryGrainStorage("Default");

builder.AddProject<Projects.OrleansServer>("silo")
.WithReference(orleans);
Expand Down