Skip to content

Fix inconsistent trace detail spacing #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 2 commits into from
Jan 26, 2024
Merged

Fix inconsistent trace detail spacing #1863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a1d299
Fix inconsistent trace detail spacing
JamesNK Jan 26, 2024
49e98f3
Clean up
JamesNK Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/Aspire.Dashboard/Components/Pages/TraceDetail.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,26 @@
<div class="col-long-content" title="@context.GetTooltip()" @onclick="() => OnShowProperties(context)">
@{
var isServerKind = context.Span.Kind == OtlpSpanKind.Server;
var spanNameContainerStyle = $"margin-left: {(context.Depth - 1) * 15}px;";
// Indent the span name based on the depth of the span.
var marginLeft = (context.Depth - 1) * 15;

// We want to have consistent margin for both client and server spans.
string spanNameContainerStyle;
if (!isServerKind)
{
spanNameContainerStyle += $"border-left-color: {ColorGenerator.Instance.GetColorHexByKey(GetResourceName(context.Span.Source))}; border-left-width: 5px; border-left-style: solid; padding-left: 5px;";
// Client span has 19px extra content:
// - 5px border
// - 9px padding-left
// - 5px extra margin-left
marginLeft += 5;
spanNameContainerStyle = $"margin-left: {marginLeft}px; border-left-color: {ColorGenerator.Instance.GetColorHexByKey(GetResourceName(context.Span.Source))}; border-left-width: 5px; border-left-style: solid; padding-left: 9px;";
}
else
{
// Server span has 19px extra content:
// - 16px icon
// - 3px padding-left
spanNameContainerStyle = $"margin-left: {marginLeft}px;";
}
}
<span class="span-name-container" style="@spanNameContainerStyle">
Expand Down