Skip to content
Merged
Show file tree
Hide file tree
Changes from 79 commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
d9500a1
Add AddDenoApp for Deno-native apps
rickylabs Jul 2, 2026
6f6a2f0
feat(hosting-js): full Deno flag surface for AddDenoApp
rickylabs Jul 3, 2026
9fe71cf
feat(hosting-js): pre-cache Deno image deps, set NODE_ENV, document s…
rickylabs Jul 3, 2026
f508946
feat(vscode-ext): add Deno debug adapter chain for AddDenoApp
rickylabs Jul 3, 2026
d5a3a1b
Fix Deno flag docs markdown lint
adamint Jul 4, 2026
e59d3a6
Fix Deno hosting debugger and publish behavior
adamint Jul 4, 2026
817bde3
Fix Deno task import map args
adamint Jul 4, 2026
227f040
Fix Deno task publish cache args
adamint Jul 6, 2026
ff1ce1f
Address Deno review feedback
davidfowl Jul 25, 2026
942524e
Merge main into Deno hosting PR
davidfowl Jul 25, 2026
abacdca
Fix Deno review feedback
davidfowl Jul 25, 2026
e7f81b7
Handle Deno task debug launches
davidfowl Jul 25, 2026
5c29498
Fix remaining Deno hosting feedback
davidfowl Jul 25, 2026
36b0b42
Address Deno follow-up review feedback
davidfowl Jul 25, 2026
d432598
Fix Deno publish edge cases
davidfowl Jul 25, 2026
38d1ebe
Fix Deno package-manager review feedback
davidfowl Jul 25, 2026
c9d6eb2
Address Deno hosting review coverage
davidfowl Jul 25, 2026
353ab42
Address Deno hosting review feedback
davidfowl Jul 25, 2026
b0fd0a0
Address Deno reviewer suppressed-comment feedback
davidfowl Jul 26, 2026
1ab7ffa
Align generated Deno package-script Dockerfile with Deno's Docker gui…
davidfowl Jul 26, 2026
b7d5be8
Reject comma-containing Deno permission values and correct deno serve…
davidfowl Jul 26, 2026
b81b01e
Reject serve host/port overrides and keep watch flags exclusive
davidfowl Jul 26, 2026
add3fb1
Follow POSIX double-quote escaping and generalize package-script docs
davidfowl Jul 26, 2026
bf6209f
Resolve the build image from the package manager when only a runtime …
davidfowl Jul 26, 2026
cf96718
Harden Deno shell boundary, flag conflicts, path checks, and permissi…
davidfowl Jul 26, 2026
6484832
Document generalized Deno managed-flag conflicts and cache-policy sup…
davidfowl Jul 26, 2026
cf9538e
Remove trailing blank line in deno-flag-surface.md
davidfowl Jul 26, 2026
ccbeb8c
Quote all Dockerfile RUN commands, reject unterminated quotes, fix in…
davidfowl Jul 26, 2026
06e6622
Forward resolution flags to deno cache and withdraw the serve endpoin…
davidfowl Jul 26, 2026
da8d131
Correct the PublishAsPackageScript docs about Deno dependency caching
davidfowl Jul 26, 2026
ea0d8b5
Unify Deno path validation and cover config aliases
davidfowl Jul 27, 2026
b5446ff
Address Deno integration review feedback
davidfowl Jul 29, 2026
11d007e
Address final Deno review feedback
davidfowl Jul 30, 2026
4360405
Honor OTLP protocol in Docker Compose
davidfowl Jul 30, 2026
78e9a72
Reject dotenv files in generated Deno images
davidfowl Jul 30, 2026
f0a85bb
Fix Deno permission and path validation
davidfowl Jul 30, 2026
e25f047
Keep Deno runnable without an OTLP endpoint
davidfowl Jul 30, 2026
36a5310
Document launch configuration callback context design
Aug 5, 2026
fc48eb7
docs: add launch configuration callback plan
Aug 6, 2026
ad326ea
Add launch configuration callback context
Aug 6, 2026
bfb9027
Fix launch producer restart handling
Aug 6, 2026
9a8c99a
Reset debug execution before rebuilding arguments
Aug 6, 2026
e9ea853
Migrate debug launch configuration producers
Aug 6, 2026
9efdff8
Finalize debug callback context API
Aug 6, 2026
65a56a7
Migrate debug support playground
Aug 6, 2026
ac32975
Fix debug support documentation whitespace
Aug 6, 2026
b0fcfd3
Address callback context review findings
Aug 6, 2026
8de33ce
Remove agent planning artifacts and restore load-bearing comments
Aug 7, 2026
900a331
Fix MAUI launch configuration regression and rename PrepareObjects
Aug 7, 2026
7d4d8fe
Address launch configuration context review
Aug 8, 2026
0ee07ef
Install Azure Functions Core Tools from release archive
Aug 8, 2026
2db433e
Recompute debug argument callbacks after original snapshot
Aug 8, 2026
6cb79d3
Validate legacy debug producer return type
Aug 8, 2026
1481f78
Revert unrelated Azure Functions tool install change
Aug 8, 2026
dcf4b09
Preserve launch override process args
Aug 8, 2026
024577a
Fix debug executable configuration snapshots
adamint Aug 9, 2026
24588ab
Reuse original argument resolutions across the debug rewrite
adamint Aug 9, 2026
5b8d2f3
Address review findings on debug launch configuration
adamint Aug 9, 2026
92901b8
Fix debug argument rewrite reuse and legacy overload validation
adamint Aug 10, 2026
64dd50d
Address debug launch context review feedback
Aug 10, 2026
3b95b28
Merge branch 'main' into adamint/issue-18956-launch-config-context
adamint Aug 10, 2026
a904ac7
Prevent later arg mutations from stripping debug-injected arguments
Aug 10, 2026
30d272c
Narrow debug launch context to resolved environment
Aug 10, 2026
35bea19
Clarify process-mode launch producer behavior
Aug 11, 2026
fa5c96c
Fix launch-override producer wiring
Aug 11, 2026
c5855b8
Clarify asynchronous debug producer guidance
Aug 11, 2026
7cdb91a
Cover the no-fallback rule when a launch configuration producer throws
Aug 11, 2026
b739005
Merge branch 'main' into adamint/issue-18956-launch-config-context
Aug 12, 2026
629c3ea
Merge remote-tracking branch 'upstream/main' into adamint/issue-18956…
Aug 13, 2026
130043f
Merge PR 19077 launch configuration changes
Aug 13, 2026
7447fcd
Merge latest main into Deno hosting PR
Aug 13, 2026
b9856e8
Document JavaScript runtime-specific hosting APIs
Aug 13, 2026
854a5a6
Validate Deno APIs through polyglot AppHosts
Aug 13, 2026
443c9f3
Honor OTLP protocols in Kubernetes publishing
Aug 13, 2026
7ae5fe6
Optimize Deno package-script Dockerfile layers
Aug 13, 2026
96cec63
Enable Deno telemetry only with OTLP endpoints
Aug 13, 2026
a842d49
Address Deno review follow-ups
Aug 13, 2026
50f3c87
Trigger Deno CI
Aug 13, 2026
9d03991
Use repository-local Deno setup action
Aug 13, 2026
ad47f25
Handle Deno entrypoint paths on Windows
Aug 13, 2026
a852b43
Fix final Deno CI dependencies
Aug 13, 2026
ecaf33f
Use HTTP for Deno telemetry validation
Aug 13, 2026
8bdb11f
Address final Deno hosting review feedback
Aug 13, 2026
4b0cfb9
Merge main into Deno hosting branch
Aug 13, 2026
1558a2d
Fix OTLP activation in publishers
Aug 13, 2026
a50d77c
Reject unsupported Deno publish modes
Aug 13, 2026
8198435
Fix explicit Deno launch metadata
Aug 13, 2026
ffd290c
Reject invalid Deno permission values
Aug 13, 2026
46c55c2
Merge origin/main into Deno hosting
sebastienros Sep 1, 2026
61f50c6
Fix late Deno debugger cleanup registration
sebastienros Sep 1, 2026
459393a
Fix Deno Python AppHost type validation
sebastienros Sep 2, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions .github/actions/setup-deno/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
name: 'Setup Deno'
description: 'Installs the pinned Deno version used by Aspire tests'

runs:
using: 'composite'
steps:
- name: Install Deno (Linux/macOS)
if: runner.os != 'Windows'
shell: bash
run: |
case "${{ runner.os }}-${{ runner.arch }}" in
Linux-X64)
TARGET="x86_64-unknown-linux-gnu"
SHA256="96c9c73fc05ea57603bc28d8071d41e861bd40bcf2a9f849dd5969ed1a2c8498"
;;
Linux-ARM64)
TARGET="aarch64-unknown-linux-gnu"
SHA256="a0f266eb189af2f27db0c6dcf9eb2f68ba2e8bbff1442c969ace398463f8b2bf"
;;
macOS-X64)
TARGET="x86_64-apple-darwin"
SHA256="04f71604d738ef2a3b0c08d00743b1a6580fd65d0dab604da2f57f30f4c74b55"
;;
macOS-ARM64)
TARGET="aarch64-apple-darwin"
SHA256="2d11cf0505d4600a4492de8d07456a7a5e7eedebf68bdcbcb9092f520fcde0f1"
;;
*)
echo "Unsupported runner: ${{ runner.os }}-${{ runner.arch }}" >&2
exit 1
;;
esac

INSTALL_DIR="${RUNNER_TEMP}/deno-2.9.0"
ARCHIVE="${RUNNER_TEMP}/deno-${TARGET}.zip"
curl --fail --location --retry 5 --output "$ARCHIVE" \
"https://github.com/denoland/deno/releases/download/v2.9.0/deno-${TARGET}.zip"

if [ "${{ runner.os }}" = "macOS" ]; then
echo "${SHA256} ${ARCHIVE}" | shasum --algorithm 256 --check
else
echo "${SHA256} ${ARCHIVE}" | sha256sum --check
fi

mkdir -p "$INSTALL_DIR"
unzip -q "$ARCHIVE" -d "$INSTALL_DIR"
chmod +x "$INSTALL_DIR/deno"
echo "$INSTALL_DIR" >> "$GITHUB_PATH"
"$INSTALL_DIR/deno" --version

- name: Install Deno (Windows)
if: runner.os == 'Windows'
shell: pwsh
run: |
$target, $sha256 = switch ("${{ runner.arch }}") {
"X64" {
"x86_64-pc-windows-msvc"
"37e3a8e5f4ee360d08bbeec9ee07fdcaa9dcd1a39d4aeaac5807354aec557451"
}
"ARM64" {
"aarch64-pc-windows-msvc"
"de3d31811dd583d6b15746db1463bebc204118aa0e8b3fe2b5ecc488ed198cbf"
}
default {
Write-Error "Unsupported runner: Windows-${{ runner.arch }}"
exit 1
}
}

$installDir = Join-Path $env:RUNNER_TEMP "deno-2.9.0"
$archive = Join-Path $env:RUNNER_TEMP "deno-$target.zip"
Invoke-WebRequest `
-Uri "https://github.com/denoland/deno/releases/download/v2.9.0/deno-$target.zip" `
-OutFile $archive

$actualHash = (Get-FileHash -Algorithm SHA256 $archive).Hash
if ($actualHash -ne $sha256) {
Write-Error "Deno archive checksum mismatch. Expected $sha256, got $actualHash."
exit 1
}

New-Item -ItemType Directory -Force -Path $installDir | Out-Null
Expand-Archive -Path $archive -DestinationPath $installDir -Force
$installDir | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
& (Join-Path $installDir "deno.exe") --version
13 changes: 13 additions & 0 deletions .github/workflows/extension-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,15 @@ jobs:
cliBinary: aspire
useXvfb: true
installAzureFunctions: true
- name: Linux
shardName: deno-debugger
spec: out/test-e2e/test-e2e/denoDebugger.e2e.test.js
runner: ubuntu-latest
rid: linux-x64
archivePattern: aspire-cli-linux-x64*.tar.gz
cliBinary: aspire
useXvfb: true
installDeno: true
defaults:
run:
shell: pwsh
Expand Down Expand Up @@ -331,6 +340,10 @@ jobs:
with:
global-json-file: global.json

- name: Setup Deno
if: ${{ matrix.installDeno }}
uses: ./.github/actions/setup-deno

- name: Download VSIX
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
Expand Down
52 changes: 51 additions & 1 deletion .github/workflows/polyglot-validation/test-python-playground.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
# Polyglot SDK Validation - Python validation AppHosts
# Iterates all Python validation AppHosts under tests/PolyglotAppHosts/*/Python,
# runs 'aspire restore --apphost' to regenerate the per-integration .aspire/modules/ SDK, and
# compiles each AppHost with the generated Python modules to verify syntax.
# compiles each AppHost with the generated Python modules. The JavaScript fixture also executes
# its Deno calls against the generated SDK without starting an AppHost or external services.
set -euo pipefail

echo "=== Python Validation AppHost Codegen Validation ==="
Expand Down Expand Up @@ -91,6 +92,55 @@ INNERPY
continue
fi

if [ "$integration_name" = "Aspire.Hosting.JavaScript" ]; then
echo " -> generated Deno SDK execution..."
if ! PYTHONPATH=".aspire/modules" python3 - <<'INNERPY'
import apphost
import aspire_app


# Syntax compilation does not resolve Python attributes. This client lets the fixture call the
# generated builder and Deno resource classes while keeping every capability invocation in-process.
class ValidationClient:
def __init__(self):
self.next_handle = 0

def create_handle(self, type_id):
self.next_handle += 1
return aspire_app.Handle({
"$handle": str(self.next_handle),
"$type": type_id,
})

def invoke_capability(self, capability_id, args, kwargs=None):
if capability_id == "Aspire.Hosting/createBuilder":
return self.create_handle("Aspire.Hosting/IDistributedApplicationBuilder")
if capability_id == "Aspire.Hosting.JavaScript/addDenoApp":
handle = self.create_handle("Aspire.Hosting.JavaScript/DenoAppResource")
return aspire_app.DenoAppResource(handle, self)

return next(
value for value in args.values()
if isinstance(value, aspire_app.Handle)
)

def disconnect(self):
pass


client = ValidationClient()
options = aspire_app.CreateBuilderOptions()
with aspire_app.DistributedApplicationBuilder(client, options) as builder:
apphost.add_deno_app(builder)
INNERPY
then
echo " ERROR: generated Deno SDK execution failed for $integration_name"
FAILED+=("$integration_name (generated Deno SDK execution)")
echo ""
continue
fi
fi

echo " OK: $integration_name passed"
PASSED+=("$integration_name")
echo ""
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ jobs:
env:
DOTNET_INSTALL_DIR: ${{ env.DOTNET_ROOT }}

- name: Setup Deno
if: inputs.testShortName == 'Hosting.JavaScript'
uses: ./.github/actions/setup-deno

- name: Trust HTTPS development certificate (Linux)
if: runner.os == 'Linux'
# Allow the task to succeed on partial trust.
Expand Down
6 changes: 6 additions & 0 deletions extension/loc/xlf/aspire-vscode.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions extension/package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@
"aspire-vscode.strings.disconnectingFromSession": "Disconnecting from Aspire debug session... Child processes will be stopped.",
"aspire-vscode.strings.processExitedWithCode": "Process exited with code {0}.",
"aspire-vscode.strings.failedToStartPythonProgram": "Failed to start Python program: {0}.",
"aspire-vscode.strings.denoInspectorPortAllocationFailed": "Failed to allocate a Deno inspector port.",
Comment thread
davidfowl marked this conversation as resolved.
Resolved
"aspire-vscode.strings.denoTaskDebuggingUnsupported": "Deno task launches cannot be debugged automatically because Deno does not accept inspector flags on the task subcommand. Use a direct Deno entrypoint for Aspire debugging, or configure and launch a Deno task that starts with an inspector flag manually.",
"aspire-vscode.strings.csharpSupportNotEnabled": "C# support is not enabled in this workspace. This project should have started through the Aspire CLI.",
"aspire-vscode.strings.failedToStartProject": "Failed to start project: {0}.",
"aspire-vscode.strings.dcpServerNotInitialized": "DCP server not initialized - cannot forward debug output.",
Expand Down
4 changes: 4 additions & 0 deletions extension/src/capabilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export type Capability =
| 'node' // Support for running Node.js projects
| 'bun' // Support for running Bun projects
| 'oven.bun-vscode' // Bun debug adapter extension identifier
| 'deno' // Support for running Deno projects (built-in to VS Code via js-debug)
| 'browser' // Support for browser debugging (built-in to VS Code via js-debug)
| 'maui' // Support for running .NET MAUI projects
| 'ms-dotnettools.dotnet-maui' // MAUI debug adapter extension identifier
Expand Down Expand Up @@ -102,6 +103,9 @@ export function getSupportedCapabilities(): Capabilities {
capabilities.push("oven.bun-vscode");
}

// Deno debugging uses VS Code's built-in js-debug, so no extension probe is required.
capabilities.push("deno");

if (isMauiInstalled()) {
capabilities.push("maui");
capabilities.push("ms-dotnettools.dotnet-maui");
Expand Down
10 changes: 8 additions & 2 deletions extension/src/dcp/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function isGoLaunchConfiguration(obj: any): obj is GoLaunchConfiguration
}

export interface JavaScriptRuntimeLaunchConfiguration extends ExecutableLaunchConfiguration {
type: "node" | "bun";
type: "node" | "bun" | "deno";
script_path?: string;
runtime_executable?: string;
working_directory?: string;
Expand All @@ -69,7 +69,7 @@ export interface JavaScriptRuntimeLaunchConfiguration extends ExecutableLaunchCo
}

export function isJavaScriptRuntimeLaunchConfiguration(obj: any): obj is JavaScriptRuntimeLaunchConfiguration {
return obj && (obj.type === 'node' || obj.type === 'bun');
return obj && (obj.type === 'node' || obj.type === 'bun' || obj.type === 'deno');
}

export type NodeLaunchConfiguration = JavaScriptRuntimeLaunchConfiguration & { type: "node" };
Expand All @@ -84,6 +84,12 @@ export function isBunLaunchConfiguration(obj: any): obj is BunLaunchConfiguratio
return obj && obj.type === 'bun';
}

export type DenoLaunchConfiguration = JavaScriptRuntimeLaunchConfiguration & { type: "deno" };

export function isDenoLaunchConfiguration(obj: any): obj is DenoLaunchConfiguration {
return obj && obj.type === 'deno';
}

export interface BrowserLaunchConfiguration extends ExecutableLaunchConfiguration {
type: "browser";
url?: string;
Expand Down
4 changes: 4 additions & 0 deletions extension/src/debugger/AspireDebugSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1451,6 +1451,10 @@ export class AspireDebugSession implements vscode.DebugAdapter {
return await vscode.debug.startDebugging(workspaceFolder, debugConfig, parentSession);
}

registerResourceCleanup(disposable: vscode.Disposable): void {
this._disposables.push(disposable);
}
Comment thread
sebastienros marked this conversation as resolved.
Resolved

private getDebugSessionWorkspaceFolder(debugConfig: AspireResourceExtendedDebugConfiguration): vscode.WorkspaceFolder | undefined {
const resourcePath = typeof debugConfig.cwd === 'string'
? debugConfig.cwd
Expand Down
3 changes: 3 additions & 0 deletions extension/src/debugger/debuggerExtensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { browserDebuggerExtension } from "./languages/browser";
import { azureFunctionsDebuggerExtension } from "./languages/azureFunctions";
import { goDebuggerExtension } from "./languages/go";
import { bunDebuggerExtension } from "./languages/bun";
import { denoDebuggerExtension } from "./languages/deno";
import { mauiDebuggerExtension } from "./languages/maui";
import { isDirectory } from "../utils/io";
import { waitForRunStartIdle } from "./runStartRegistry";
Expand Down Expand Up @@ -114,6 +115,8 @@ export function getResourceDebuggerExtensions(): ResourceDebuggerExtension[] {
extensions.push(bunDebuggerExtension);
}

extensions.push(denoDebuggerExtension);

if (isMauiInstalled()) {
extensions.push(mauiDebuggerExtension);
}
Expand Down
Loading
Loading