Skip to content

[release/13.4] Bump StreamJsonRpc to 2.25.29 to clear MessagePack NU1903 #18204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 8 commits into from
Jun 16, 2026
Merged

[release/13.4] Bump StreamJsonRpc to 2.25.29 to clear MessagePack NU1903 #18204

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e3c4f46
Bump StreamJsonRpc to 2.25.25 to clear MessagePack NU1903
mitchdenny Jun 12, 2026
32a5f5d
Pin MessagePack to 2.5.302 to fully clear GHSA-hv8m-jj95-wg3x
mitchdenny Jun 12, 2026
0b09b21
Revert StreamJsonRpc bump; keep MessagePack 2.5.302 pin
mitchdenny Jun 12, 2026
4b90c84
Bump StreamJsonRpc to 2.25.28 and drop MessagePack pin
mitchdenny Jun 14, 2026
4e3477c
Strip StreamJsonRpc analyzer from consumer AppHost builds
mitchdenny Jun 14, 2026
8a27d2b
Move StreamJsonRpc analyzer strip to Aspire.Hosting buildTransitive
mitchdenny Jun 14, 2026
4b9e4fc
Simplify StreamJsonRpc analyzer-strip condition using %(Filename)
mitchdenny Jun 15, 2026
edd9609
Bump StreamJsonRpc to 2.25.29; drop analyzer-strip workaround
Copilot Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
<PackageVersion Include="StackExchange.Redis" Version="2.13.1" />
<PackageVersion Include="System.IO.Hashing" Version="10.0.8" />
<PackageVersion Include="Yarp.ReverseProxy" Version="2.3.0" />
<PackageVersion Include="StreamJsonRpc" Version="2.22.23" />
<PackageVersion Include="StreamJsonRpc" Version="2.25.28" />
<PackageVersion Include="Semver" Version="3.0.0" />
<PackageVersion Include="Sigstore" Version="0.5.0" />
<PackageVersion Include="Tuf" Version="0.5.0" />
Expand Down
14 changes: 13 additions & 1 deletion src/Aspire.Hosting/Aspire.Hosting.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,19 @@
<PackageReference Include="AspNetCore.HealthChecks.Uris" />
<PackageReference Include="Semver" />
<PackageReference Include="System.IO.Hashing" />
<PackageReference Include="StreamJsonRpc" />
<!--
StreamJsonRpc 2.25.28 brings MessagePack 2.5.302 transitively (clears
GHSA-hv8m-jj95-wg3x / CVE-2026-48109 for downstream consumers like AppHost
projects generated by `dotnet new aspire-starter`). However, the StreamJsonRpc
nupkg ships an analyzer assembly built against Roslyn 4.14, which is newer
than the Roslyn 4.11 shipped in the .NET 8 SDK that our template tests use to
build generated AppHost projects — that triggers CSC error CS9057. We don't
use any of the StreamJsonRpc analyzers in this assembly, so ExcludeAssets
skips them without affecting runtime behavior. Remove the ExcludeAssets once
our template-test toolchain moves to a .NET SDK with Roslyn >= 4.14.
See microsoft/vs-streamjsonrpc#1459.
-->
<PackageReference Include="StreamJsonRpc" ExcludeAssets="analyzers" />
</ItemGroup>

<ItemGroup>
Expand Down
18 changes: 18 additions & 0 deletions src/Aspire.Hosting/buildTransitive/Aspire.Hosting.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,22 @@
<Analyzer Include="$(_AspireIntegrationAnalyzerAssembly)" Condition="Exists('$(_AspireIntegrationAnalyzerAssembly)')" />
</ItemGroup>

<!--
StreamJsonRpc 2.25+ ships an analyzer (StreamJsonRpc.Analyzers.dll) built against
Roslyn 4.14. When a consumer project is built with the .NET 8 SDK (Roslyn 4.11),
the C# compiler fails to load the analyzer with CSC error CS9057. The .NET 8 SDK
discovers analyzer assemblies from the NuGet cache by convention, so the
ExcludeAssets="analyzers" flag on our PackageReference is not enough to keep the
analyzer out of the consumer compile. Aspire does not depend on any StreamJsonRpc
analyzer diagnostic, so unconditionally remove it from the Analyzer item set
before compile. Applied via buildTransitive so it reaches any consumer that
pulls Aspire.Hosting in (e.g. via Aspire.Hosting.AppHost or Aspire.Hosting.Testing).
See: https://github.com/microsoft/vs-streamjsonrpc/pull/1459
-->
<Target Name="_AspireRemoveStreamJsonRpcAnalyzer" BeforeTargets="CoreCompile">
<ItemGroup>
<Analyzer Remove="@(Analyzer)" Condition="'%(Filename)' == 'StreamJsonRpc.Analyzers' or '%(Filename)' == 'StreamJsonRpc.Analyzers.CodeFixes'" />
</ItemGroup>
</Target>

</Project>
Loading