Report copilot-cli specifically & update tests to work in test explorer#18094
Merged
Conversation
DamianEdwards
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
14 tasks
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18094Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18094" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes two focused changes: (1) renames the detected Copilot coding agent telemetry value from "copilot" to "copilot-cli" for specificity (removing COPILOT_AGENT from detection rules since it's set by the broader coding agent, not the CLI specifically), and (2) refactors the CodingAgentTelemetryTestCases from Dictionary<string, string?> parameters to (string, string?) tuples so tests serialize correctly and appear as individual entries in the test explorer.
Changes:
- Renames the copilot agent detection name to
"copilot-cli"and removesCOPILOT_AGENTfrom its detection variable list inCodingAgentDetector.cs - Converts test data from Dictionary-based multi-entry parameters to single-tuple parameters for xUnit test explorer compatibility
- Removes multi-agent combination test cases (these can't be expressed with single-tuple parameterization)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Cli/Telemetry/CodingAgentDetector.cs | Renames agent from "copilot" to "copilot-cli", removes COPILOT_AGENT env var, reorders COPILOT_CLI to front |
| tests/Aspire.Cli.Tests/Telemetry/AspireCliTelemetryTests.cs | Refactors test method to accept tuple instead of Dictionary; updates expected values to "copilot-cli"; adds COPILOT_AGENT → null test; removes multi-agent combination test cases |
… agents; update tests for new detection logic
davidfowl
approved these changes
Jun 10, 2026
Contributor
|
❌ CLI E2E Tests failed — 112 passed, 1 failed, 2 unknown (commit ❌ Failed Tests
View all recordings
📹 Recordings uploaded automatically from CI run #27301403912 |
Contributor
|
✅ No documentation update needed. docs_optional → internal_refactor: No documentation update needed.
|
Member
Author
|
/backport to release/13.4 |
Contributor
|
Started backporting to |
Contributor
|
@DamianEdwards backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Report copilot-cli specifically & update tests to work in test explorer
Using index info to reconstruct a base tree...
A src/Aspire.Cli/Telemetry/CodingAgentDetector.cs
M tests/Aspire.Cli.Tests/Telemetry/AspireCliTelemetryTests.cs
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/Aspire.Cli/Telemetry/CodingAgentDetector.cs deleted in HEAD and modified in Report copilot-cli specifically & update tests to work in test explorer. Version Report copilot-cli specifically & update tests to work in test explorer of src/Aspire.Cli/Telemetry/CodingAgentDetector.cs left in tree.
Auto-merging tests/Aspire.Cli.Tests/Telemetry/AspireCliTelemetryTests.cs
CONFLICT (content): Merge conflict in tests/Aspire.Cli.Tests/Telemetry/AspireCliTelemetryTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Report copilot-cli specifically & update tests to work in test explorer
Error: The process '/usr/bin/git' failed with exit code 128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report copilot-cli specifically & update tests to work in test explorer
Reports detection of
copilotCLI ascopilot-clito be more specific than justcopilotand addresses PR comment https://github.com/microsoft/aspire/pull/18065/changes#r3390821123Checklist