[release/13.4] Add persistent container test coverage - #17884
[release/13.4] Add persistent container test coverage#17884Jose Perez Rodriguez (joperezr) merged 15 commits into
Conversation
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Use an isolated user-secrets store for persistent container test runs so integration defaults can persist generated parameters across AppHost restarts. Avoid the CI container registry override for Azurite because the mirrored tag is unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Let persistent container tests use the same container registry configuration path as normal TestDistributedApplicationBuilder usage instead of forcing the test mirror from the helper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid blocking the test server on dependency health checks in the CLI E2E scenario. The endpoint verification already retries real Redis, PostgreSQL, and Azure Storage operations after the resources have started. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assert persistent container tests observe container.lifetime=Persistent and compare the actual container.id across AppHost runs instead of the stable DCP resource ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17884Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17884" |
|
❓ CLI E2E Tests unknown — 111 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26909928293 |
|
This is test only so doesn't really need tactics approval. That said, I'm curious David Negstad (@danegsta), how stable do you think these tests will be? Biggest concern is the fact that these are dealing with docker and containers so we just want to make sure that we are not making the situation worse, so if there is a chance of them being flaky, let's make sure the right retries etc are in place |
|
Merging this as this is release anyway. If we need retries let's add those to main |
7b53b8c
into
release/13.4
|
✅ No documentation update needed. docs_optional →
|
Backport of #17871 to release/13.4
/cc David Negstad (@danegsta) Copilot
Customer Impact
N/A - Additional test coverage for container based integrations using persistent lifetime
Testing
Risk
Regression?