Improve parameter display in VS Code extension by ellahathaway · Pull Request #17881 · microsoft/aspire

Ella Hathaway (ellahathaway) · 2026-06-03T19:25:04Z

Parameters now display consistently in both the resource tree and the inline apphost CodeLens, matching the Aspire dashboard.

What changed

Missing values show as Value missing with a warning icon, instead of the
raw ValueMissing state string.
Parameter values are shown inline next to the resource state:
- Secret parameters display a masked value (●●●●●●●●).
- Non-secret values display their text, truncated to 80 characters with an
  ellipsis so a row stays readable.
- Parameters with no value show no value (just the "Value missing" state).
Command order matches the dashboard — set-parameter now appears before
delete-parameter instead of being alphabetically sorted.

Before / after

	Before	After
Missing value	`ValueMissing`	⚠️ Value missing
Secret value	(no value shown)	`●●●●●●●●`
Long value	(no value shown)	`the-value…` (≤80 chars)
Command order	delete-parameter, set-parameter	set-parameter, delete-parameter

Show parameter values in the resource tree consistently with the dashboard: mask secrets with a fixed 8-bullet string, truncate long non-secret values, and surface a "Value missing" state. Preserve AppHost command registration order in the CLI include-disabled stream so set-parameter shows before delete-parameter. Fixes microsoft#17193

github-actions · 2026-06-03T19:26:04Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17881

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17881"

Mirror the tree-view parameter improvements on the inline apphost CodeLens: - ValueMissing renders as "Value missing" with a warning icon. - Add a value lens showing the parameter value (secrets masked, long values truncated to 80 chars) inline next to the state. - Reuse the exported getParameterValueDescription so masking/truncation matches the tree and dashboard. - Preserve command registration order in the tree Commands node (set-parameter before delete-parameter) to match the dashboard.

…text The CodeLens tooltip was using the raw state string (e.g. 'ValueMissing') while the title already used the localized label. Export getResourceStateDescription and use it in the tooltip so it shows 'Value missing' consistently. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates command ordering semantics between API/UI backchannel streams and improves parameter UX in the VS Code extension (new ValueMissing state + inline parameter value display with masking/truncation).

Changes:

Preserve AppHost registration order for commands when includeDisabledCommands: true, while keeping default/API stream alphabetically sorted.
Add ValueMissing resource state support and humanized display text in tree/tooltips/code lenses.
Display Parameter values inline (tree + code lens), masking secrets and truncating long values.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/Aspire.Cli.Tests/Backchannel/ResourceSnapshotMapperTests.cs	Updates/extends tests to validate different command ordering contracts per stream.
src/Aspire.Cli/Backchannel/ResourceSnapshotMapper.cs	Implements conditional command ordering depending on `includeDisabledCommands`.
extension/src/views/AspireAppHostTreeProvider.ts	Humanizes `ValueMissing`, shows/masks/truncates parameter values, and preserves command order in the tree.
extension/src/editor/AspireCodeLensProvider.ts	Adds `ValueMissing` label and an additional parameter value code lens.
extension/src/editor/resourceConstants.ts	Adds `ValueMissing` state and constants for parameter command/property names.
extension/src/loc/strings.ts	Adds localized strings for “Value missing” (tree) and code lens label (with warning icon).
extension/package.nls.json	Adds NLS entry for `parameterValueMissing`.
extension/loc/xlf/aspire-vscode.xlf	Adds XLF entry for `parameterValueMissing`.
extension/src/test/codeLens.test.ts	Adds unit coverage for `ValueMissing` code lens label.
extension/src/test/aspireCodeLensProvider.test.ts	Adds coverage for parameter value code lens behavior (mask/truncate/missing).
extension/src/test/appHostTreeView.test.ts	Adds coverage for warning icon, parameter description behavior, tooltip state, and command ordering in quick pick.

Move getResourceStateDescription/getParameterValueDescription and the mask/truncation constants out of the AspireAppHostTreeProvider view module into a new extension/src/utils/resourceDisplay.ts, so AspireCodeLensProvider no longer depends on the view layer. Pure move; no behavior change.

github-actions · 2026-06-03T22:39:03Z

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Tests / Hosting-2 / Hosting-2 (windows-latest) - Job-level runner or infrastructure failure matched the transient allowlist.

Adam Ratzman (adamint) · 2026-06-04T17:11:27Z

Tested with the PR CLI artifact 13.5.0-pr.17881.gb318ea0e (matches b318ea0e). aspire new aspire-starter against the PR hive completed successfully, and ResourceSnapshotMapperTests passed locally (17 tests). No new review comments from me.

Adam Ratzman (adamint)

Reviewed with four dedicated passes. I did not find any new, non-duplicate high-confidence issues to raise.

Add a RegistrationOrder field to the command JSON contract carrying each command's AppHost registration index, and sort commands in the VS Code extension by (RegistrationOrder, Name). This makes the resource tree, command quick pick, and CodeLens follow the dashboard's registration ordering instead of the alphabetical JSON key order.

Consolidate the resource command comparator alongside the other resource display helpers and remove the standalone resourceCommands.ts module.

James Newton-King (JamesNK) · 2026-06-05T02:56:05Z

+    /// The zero-based index at which the command was registered.
+    /// </summary>
+    [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+    public int? RegistrationOrder { get; set; }


Rename this to SortOrder. That's the name we use in other places, e.g. urls

James Newton-King (JamesNK) · 2026-06-05T02:58:05Z

-            .OrderBy(c => c.Name)
+            .Select((command, index) => (command, index))
+            .Where(c => IsCommandVisibleForConsumer(c.command.Visibility, includeDisabledCommands) && IsCommandVisibleToConsumer(c.command.State, includeDisabledCommands))
+            .OrderBy(c => c.command.Name)


This orderby seems redundent.

…der and remove redundant OrderBy Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>

David Fowler (davidfowl) · 2026-06-05T04:36:11Z

This is pretty slick

…ilename globs match nested paths Three automated PRs in the last 14d fired more tests than they needed to: #17672, #17263 [Automated] Update ATS API Surface Area #17534 Move repository skills to .agents They each touched only api/*.txt or only README/skill markdown, but were firing trigger_all or selective:integrations — burning the full ~25min CI critical path. Audit-replay over 161 merged PRs found them, plus a latent C# glob bug where bare-filename patterns silently ignored nested matches. Root causes — two independent bugs: 1. The category-trigger rescue logic in RescueCategoryTriggerFiles built a synthetic union of all category triggerPaths without consulting per-category excludePaths. An ignored file that textually matched some category's glob but was excluded from that category got rescued back to active and then hit fallback_unmatched (worse than staying ignored). For src/Aspire.Hosting.Foundry/api/*.txt this meant ATS-only PRs fired integrations even after `**/api/*.txt` was added to ignorePaths. 2. The four glob analyzers (CriticalFileDetector, IgnorePathFilter, CategoryMapper.CompiledCategory, ProjectMappingResolver.CompiledMapping) handed user-facing patterns directly to FileSystemGlobbing.Matcher. The Matcher anchors bare-filename patterns at the repo root, so `Directory.Build.props` matched only the root file, not `src/Directory.Build.props` or `tests/Directory.Build.props`. The Python audit-replay evaluator (eval_rules.py) already documented and applied a "prepend **/ to bare-filename patterns" rule; the C# analyzers did not, so the two evaluators silently disagreed on ~5 patterns across ignorePaths, triggerAllPaths, and sourceToTestMappings. The fix: - Rescue now passes config.Categories directly to CategoryMapper so CompiledCategory.Matches honors per-category excludes. A file is rescued only when at least one category would actually fire on it. - New PatternNormalization.NormalizeGlob prepends `**/` to any pattern without a path separator. Every glob entry point applies it: the four analyzers above plus ProjectMappingResolver's regex compiler. - Rules: integrations.excludePaths gains `tests/Aspire.Acquisition.Tests/**`, `tests/Infrastructure.Tests/**`, `**/*.md`, `**/api/*.txt`. The same `**/api/*.txt` exclude is added to every category so an ignored ATS file can't be rescued back by any category. ignorePaths gains `**/api/*.txt`. Acquisition mapping's source list gains the missing self-mapping `tests/Aspire.Acquisition.Tests/**` (Templates and Infrastructure mappings already had this; Acquisition was an oversight exposed only after the new exclude was added). Verification: - Audit replay over 161 merged PRs: 4 outcomes change (#17263, #17534, #17549, #17672 all move to `skip`); zero regressions; zero fallback_unmatched. - New AuditFixtureTests xUnit [Theory] replays 28 hand-validated PRs against the live audit rules. Each row is a separate test, so any future rule edit that changes a row's outcome shows up as a visible CI failure. Coverage includes templates (#16447), CLI native build (#17567), extension multi-category (#17881/17698/17772), Hosting-core trigger_all (#17879), polyglot (#17948), and the regression canaries for previous fallback_unmatched cases. - Per-component regression tests pin both bugs: two new tests in EndToEndEvaluationTests for rescue+excludes; two more for bare-filename matching at nested paths. - Three pre-existing analyzer tests had asserted the buggy bare-filename behavior as expected (e.g. `*.md` not matching `docs/guide.md`). Updated with comments explaining the user-intent rule. - Full TestSelector namespace: 290 tests, all pass. No collateral damage on the wider Infrastructure.Tests suite (5 pre-existing baseline failures unchanged). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Ella Hathaway (ellahathaway) and others added 2 commits June 3, 2026 13:39

Ella Hathaway (ellahathaway) changed the title ~~Improve parameter display in VS Code extension tree~~ Improve parameter display in VS Code extension Jun 3, 2026

Ella Hathaway (ellahathaway) marked this pull request as ready for review June 3, 2026 21:14

Ella Hathaway (ellahathaway) requested a review from Adam Ratzman (adamint) as a code owner June 3, 2026 21:14

Copilot AI review requested due to automatic review settings June 3, 2026 21:14

Ella Hathaway (ellahathaway) requested review from James Newton-King (JamesNK), David Fowler (davidfowl) and Mitch Denny (mitchdenny) as code owners June 3, 2026 21:14

Copilot AI reviewed Jun 3, 2026

View reviewed changes

James Newton-King (JamesNK) reviewed Jun 3, 2026

View reviewed changes

Comment thread src/Aspire.Cli/Backchannel/ResourceSnapshotMapper.cs Outdated

Adam Ratzman (adamint) self-assigned this Jun 4, 2026

Adam Ratzman (adamint) added the area-extension label Jun 4, 2026

Adam Ratzman (adamint) reviewed Jun 4, 2026

View reviewed changes

Ella Hathaway (ellahathaway) added 4 commits June 4, 2026 18:48

Move compareResourceCommands into resourceDisplay

32f0081

Consolidate the resource command comparator alongside the other resource display helpers and remove the standalone resourceCommands.ts module.

Remove redundant comment on ResourceCommandJson.registrationOrder

a5bd614

Simplify compareResourceCommands comment to match file style

978fce1

Ella Hathaway (ellahathaway) requested review from James Newton-King (JamesNK) and Adam Ratzman (adamint) June 4, 2026 23:58

Adam Ratzman (adamint) approved these changes Jun 5, 2026

View reviewed changes

Adam Ratzman (adamint) merged commit cad60c6 into microsoft:main Jun 5, 2026
660 of 663 checks passed

github-actions Bot added this to the 13.5 milestone Jun 5, 2026

James Newton-King (JamesNK) reviewed Jun 5, 2026

View reviewed changes

Copilot AI added a commit that referenced this pull request Jun 5, 2026

Address PR #17881 review comments: rename RegistrationOrder to SortOr…

acc83f2

…der and remove redundant OrderBy Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>

Copilot AI mentioned this pull request Jun 5, 2026

Rename RegistrationOrder to SortOrder #17935

Merged

14 tasks

github-actions Bot mentioned this pull request Jun 7, 2026

[repo-pulse] 📊 Repo Pulse — Daily Activity Dashboard #16404

Open

Jose Perez Rodriguez (joperezr) mentioned this pull request Jun 8, 2026

VS Code Extension shouldn't kill a debug session if broken on a Breakpoint for over 2 minutes #18021

Closed

1 task

This was referenced Jun 9, 2026

VS Code Extension Debug Output is confusing #18047

Closed

VS Code extension dogfooding doesn't work with CLI dogfooding #18073

Closed

Unify workspace/global AppHost describe --follow streaming in VS Code extension #18123

Closed

This was referenced Jun 20, 2026

VS Code E2E tests runnng on old version #18374

Closed

Aspire VS Code extension lists code snippets from Agent Skills as AppHosts #18398

Closed

VS Code Extension: Hide "Workspace AppHosts" root node when there is only one AppHost #18420

Closed

github-actions Bot locked and limited conversation to collaborators Jul 5, 2026

Adam Ratzman (adamint) added the area-vscode label Sep 8, 2026

Navigation Menu

Uh oh!

Improve parameter display in VS Code extension - #17881

Improve parameter display in VS Code extension#17881
Adam Ratzman (adamint) merged 8 commits into
microsoft:mainfrom
ellahathaway:ellahathaway/improve-vscode-parameter-display

Ella Hathaway (ellahathaway) commented Jun 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

Uh oh!

Adam Ratzman (adamint) commented Jun 4, 2026

Uh oh!

Adam Ratzman (adamint) left a comment

Uh oh!

Uh oh!

James Newton-King (JamesNK) Jun 5, 2026

Uh oh!

James Newton-King (JamesNK) Jun 5, 2026

Uh oh!

David Fowler (davidfowl) commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Ella Hathaway (ellahathaway) commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Before / after

Uh oh!

github-actions Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

Uh oh!

Adam Ratzman (adamint) commented Jun 4, 2026

Uh oh!

Adam Ratzman (adamint) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

James Newton-King (JamesNK) Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

James Newton-King (JamesNK) Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

David Fowler (davidfowl) commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ella Hathaway (ellahathaway) commented Jun 3, 2026 •

edited

Loading

github-actions Bot commented Jun 3, 2026 •

edited

Loading