WithTerminal(): per-replica interactive terminal sessions (Aspire side, draft) - #17866

Merged

Mitch Denny (mitchdenny) merged 96 commits into

mainfrom

feature/with-terminal

Jun 10, 2026

Commits on Jun 4, 2026

Add WithTerminal API: TerminalAnnotation, TerminalHostResource, and extension method

Mitch Denny (mitchdenny)
and
Copilot
committed
3b649ab
Add Aspire Terminal Protocol spec, shared codec, and playground

Mitch Denny (mitchdenny)
and
Copilot
committed
3abd3b1
Add terminal protocol test client and verify end-to-end

Mitch Denny (mitchdenny)
and
Copilot
committed
7ce3362
Add DCP model TerminalSpec, backchannel RPC, and CLI terminal command

Mitch Denny (mitchdenny)
and
Copilot
committed
38d6785
Add WithTerminal custom socket path provider overload

Mitch Denny (mitchdenny)
and
Copilot
committed
9277b2d
Add Dashboard terminal support: xterm.js, WebSocket proxy, ConsoleLogs integration

Mitch Denny (mitchdenny)
and
Copilot
committed
2b04243
Fix Dashboard terminal: use script tags for xterm.js and int IDs for JS interop

Mitch Denny (mitchdenny)
and
Copilot
committed
f777479
Add production Aspire.TerminalHost and wire into AppHost discovery

Mitch Denny (mitchdenny)
and
Copilot
committed
50479bc
Fix playground: use custom socket path overload to avoid dual terminal host

Mitch Denny (mitchdenny)
and
Copilot
committed
ec0c756
Redesign terminal host for reconnection with state replay

Mitch Denny (mitchdenny)
and
Copilot
committed
c95cd84
WithTerminal Phase 1: refactor to per-replica UDS pair design

Mitch Denny (mitchdenny)
and
Copilot
committed
a821875
WithTerminal Phase 2: Aspire.TerminalHost on Hex1b HMP v1

Mitch Denny (mitchdenny)
and
Copilot
committed
72e784e
WithTerminal Phase 4: wire per-replica TerminalSpec into DCP ExecutableCreator

Mitch Denny (mitchdenny)
and
Copilot
committed
875a550
WithTerminal Phase 5: backchannel exposes per-replica terminal endpoints

Mitch Denny (mitchdenny)
and
Copilot
committed
8c14060
WithTerminal Phase 6: aspire terminal CLI command on Hex1b HMP v1
Mitch Denny (mitchdenny)
committed
74c39b2
Phase 7: Dashboard /api/terminal WebSocket proxy + per-replica TerminalView

Mitch Denny (mitchdenny)
and
Copilot
committed
169456f
Phase 8: WithTerminal end-to-end playground + plain-executable fix

Mitch Denny (mitchdenny)
and
Copilot
committed
f39ee87
Phase 8 fix: TerminalView reacts to resource/replica parameter changes

Mitch Denny (mitchdenny)
and
Copilot
committed
174eeee
WithTerminal: container support + Node.js playground

Mitch Denny (mitchdenny)
and
Copilot
committed
6c37e6e
Terminals playground: nodebox fix - override CMD instead of entrypoint

Mitch Denny (mitchdenny)
and
Copilot
committed
08c3615
Flip producer-side connection direction in Aspire.TerminalHost

Mitch Denny (mitchdenny)
and
Copilot
committed
d6f429d
Dashboard terminal: send resize on WebSocket open before render

Mitch Denny (mitchdenny)
and
Copilot
committed
b1214f4
WithTerminal: process-restart support + Stop-regression hardening (Phase 9d-9f)

Mitch Denny (mitchdenny)
and
Copilot
committed
17fdd7e
Phase 11: CLI wires up HMP1 multi-head primary/secondary protocol

Mitch Denny (mitchdenny)
and
Copilot
committed
813b0b0
TerminalHost: bridge consumer-side resize to raw DCP HMP1 frame

Mitch Denny (mitchdenny)
and
Copilot
committed
33036bf
Update Hex1b to 0.147.0 + transient nuget.org Hex1b-only mapping

Mitch Denny (mitchdenny)
and
Copilot
committed
efb6837
Phase 17 Dashboard: transplant WebMuxerDemo terminal chrome + dumb byte-pipe pivot

Mitch Denny (mitchdenny)
and
Copilot
committed
2dc81db
Phase 17 CLI: split TerminalCommand and lift WebMuxerDemo viewer experience

Mitch Denny (mitchdenny)
and
Copilot
committed
a1f4b44
Terminals playground: shell2 control resource for Stop bisection + sln file

Mitch Denny (mitchdenny)
and
Copilot
committed
dc10147
Update Hex1b 0.147.0 -> 0.150.0; drop transient nuget.org mapping

Mitch Denny (mitchdenny)
and
Copilot
committed
33d2b48
Adapt to Hex1b 0.150.0 and rebased main

Mitch Denny (mitchdenny)
and
Copilot
committed
5f813e8
WithTerminal Phase 18: package Aspire.TerminalHost as per-RID NuGet packages

Mitch Denny (mitchdenny)
and
Copilot
committed
e8201bc
WithTerminal Phase 19: integrate Aspire.TerminalHost into the polyglot CLI bundle

Mitch Denny (mitchdenny)
and
Copilot
committed
354ebd7
docs/specs/with-terminal: fix MD040 fenced-code-language

Mitch Denny (mitchdenny)
and
Copilot
committed
7ac56bf
WithTerminal Phase 20: fix CI failures from Phase 18/19

Mitch Denny (mitchdenny)
and
Copilot
committed
362acdb
WithTerminal Phase 22: review feedback cleanup pass 1

Mitch Denny (mitchdenny)
and
Copilot
committed
b97b221
WithTerminal Phase 22: review feedback documentation pass

Mitch Denny (mitchdenny)
and
Copilot
committed
ceaef89
WithTerminal Phase 23: aspire terminal ps command + per-replica metadata

Mitch Denny (mitchdenny)
and
Copilot
committed
053e54e
Per-replica TerminalHost: one host process per parent replica

Mitch Denny (mitchdenny)
and
Copilot
committed
f69afc1
chore: whitespace nudge to retrigger CI

Mitch Denny (mitchdenny)
and
Copilot
committed
6ad0df0
Defer per-replica TerminalHost creation to BeforeStartEvent

Mitch Denny (mitchdenny)
and
Copilot
committed
6116143
Add ATS export for WithTerminal via parameterless dispatcher overload

Mitch Denny (mitchdenny)
and
Copilot
committed
670af13
Fall back to ASPIRE_DASHBOARD_PATH when terminal host path is unset in bundle mode

Mitch Denny (mitchdenny)
and
Copilot
committed
d50d829
Drop TerminalSpec.Enabled and Windows-only gate

authored and
Mitch Denny (mitchdenny)
committed
07cd081
playground: add Unix bash shell + auto-wire TerminalHost project ref

Mitch Denny (mitchdenny)
and
Copilot
committed
8445464
Post-rebase fixups + bump Hex1b 0.154 → 0.161

Mitch Denny (mitchdenny)
and
Copilot
committed
5cf3129
Dashboard: lift terminal chrome into ConsoleLogs toolbar

Mitch Denny (mitchdenny)
and
Copilot
committed
48572e1
Dashboard: hide log-only toolbar items in terminal mode

Mitch Denny (mitchdenny)
and
Copilot
committed
d4e74a7
Dashboard: consolidate terminal primary badge + take-control button

Mitch Denny (mitchdenny)
and
Copilot
committed
2649201
Dashboard terminal: diagnostics + pooled larger outbound buffer

Mitch Denny (mitchdenny)
and
Copilot
committed
51e07d7
Dashboard terminal: faster UDS drain to avoid Hex1b slow-peer eviction

Mitch Denny (mitchdenny)
and
Copilot
committed
3d3adf2
Dashboard terminal: auto-take primary when adjusting font/size

Mitch Denny (mitchdenny)
and
Copilot
committed
bb70bbb
Dashboard terminal: apply local size before auto-promoting

Mitch Denny (mitchdenny)
and
Copilot
committed
2122e28
Dashboard terminal: theme-aware stage background + Aspire-purple glow

Mitch Denny (mitchdenny)
and
Copilot
committed
0904bdd
Dashboard terminal: bundle Cascadia Mono NF for Powerline/Nerd glyphs

Mitch Denny (mitchdenny)
and
Copilot
committed
9cd66d1
Dashboard terminal: preload Cascadia Mono NF before xterm construction

Mitch Denny (mitchdenny)
and
Copilot
committed
7ee41d1
Use term.reset() instead of term.clear() on WS reconnect

Copilot
authored and
Mitch Denny (mitchdenny)
committed
7192073
Bump Hex1b 0.161 → 0.163 + post-rebase fixups

Mitch Denny (mitchdenny)
and
Copilot
committed
8adac5c
Validate Origin on terminal WebSocket upgrade (CSWSH defense)

Mitch Denny (mitchdenny)
and
Copilot
committed
4cb1cb7
Restrict terminal-host control socket to 0600

Mitch Denny (mitchdenny)
and
Copilot
committed
688e670
Clean up terminal-host temp directory on ApplicationStopped

Mitch Denny (mitchdenny)
and
Copilot
committed
3f1dc02
Pre-delete and post-delete producer/consumer UDS files in TerminalReplica

Mitch Denny (mitchdenny)
and
Copilot
committed
f692878
WithTerminal: move per-replica UDS sockets and metadata sidecar under ~/.aspire/trmnl/

Mitch Denny (mitchdenny)
and
Copilot
committed
0a09a06
WithTerminal: rename control sock purpose 'control' -> 'ctrl'

Mitch Denny (mitchdenny)
and
Copilot
committed
e9147ed
WithTerminal: assert manifest exclusion uses Ignore singleton

Mitch Denny (mitchdenny)
and
Copilot
committed
9fdd3a6
WithTerminal: add ShowTerminalHosts option (default false)

Mitch Denny (mitchdenny)
and
Copilot
committed
7b4926c
WithTerminal: drop StderrLoggerProvider, wire OTel exporters

Mitch Denny (mitchdenny)
and
Copilot
committed
4c71b99
Drop bogus ReplicasStarted counter, add ConsumerConnections

Mitch Denny (mitchdenny)
and
Copilot
committed
c668f14
Add ILogger<T> + OTel metrics for terminal host lifecycle events

Mitch Denny (mitchdenny)
and
Copilot
committed
4b31190
Remove dashboard diagnostics instrumentation from Program.cs

Mitch Denny (mitchdenny)
and
Copilot
committed
0e4b029
Add startup OTLP env diagnostic to terminal host stderr

Mitch Denny (mitchdenny)
and
Copilot
committed
1f7016f
Distribute Aspire.TerminalHost via CLI bundle only

Mitch Denny (mitchdenny)
and
Copilot
committed
c5a2caa
Adopt DCP socketMode=connect, IHost-based terminal host, debug logging

Mitch Denny (mitchdenny)
and
Copilot
committed
64968f9
Review batch A: capability gates, doc fixes, dead code removal

Mitch Denny (mitchdenny)
and
Copilot
committed
1450045
TerminalHostArgs: adopt System.CommandLine for parsing (#6)

Mitch Denny (mitchdenny)
and
Copilot
committed
a8b3528
Review batch B: correctness/DoS/UX fixes

Mitch Denny (mitchdenny)
and
Copilot
committed
a35dd37
Review batch C: test cleanup (#21-#24)

Mitch Denny (mitchdenny)
and
Copilot
committed
ff87bfb
WithTerminal: rename ShowTerminalHosts -> ShowTerminalHost

Mitch Denny (mitchdenny)
and
Copilot
committed
0e304b5
Sdk.in.targets: revert gratuitous comment reflow

Mitch Denny (mitchdenny)
and
Copilot
committed
d08f9fe
Backchannel: consolidate Terminals_PsV1 into Terminals_V1

Mitch Denny (mitchdenny)
and
Copilot
committed
ef7b636
Comments: strip session-narration 'Phase N' references

Mitch Denny (mitchdenny)
and
Copilot
committed
d6c26ba
Terminal commands: adopt CommonCommandServices ctor

Mitch Denny (mitchdenny)
and
Copilot
committed
275fcbd
Accept codegen snapshots for WithTerminal()

Mitch Denny (mitchdenny)
and
Copilot
committed
35cae1d

Commits on Jun 5, 2026

Address @adamint review feedback on PR #17866

Mitch Denny (mitchdenny)
and
Copilot
committed
aa1f311
Dashboard: terminal UI polish

Mitch Denny (mitchdenny)
and
Copilot
committed
2099622

Commits on Jun 7, 2026

Review #17: TerminalHost failure diagnostics + comment cleanup

midenn
and
Copilot
committed
dbc5b03
CLI: always inject ASPIRE_TERMINAL_HOST_PATH from bundle

Mitch Denny (mitchdenny)
and
Copilot
committed
27ade1c
TerminalHost: tolerate transient EAGAIN/EINTR in control accept loop

Mitch Denny (mitchdenny)
and
Copilot
committed
6ea2944

Commits on Jun 9, 2026

Commits on Jun 10, 2026

Mark WithTerminal experimental + gate terminal CLI commands behind feature flag

Mitch Denny (mitchdenny)
and
Copilot
committed
4be4daa
Potential fix for pull request finding

Mitch Denny (mitchdenny)
and
Copilot
authored
a9ca800
Potential fix for pull request finding

Mitch Denny (mitchdenny)
and
Copilot
authored
c9984d9
Potential fix for pull request finding

Mitch Denny (mitchdenny)
and
Copilot
authored
9a5e42a
Add THIRD-PARTY-NOTICES entries for Cascadia Code and xterm.js

Mitch Denny (mitchdenny)
and
Copilot
committed
7505af8