Skip to content

[release/13.4] Add Aspire CLI npm package release integration - #17733

Closed
Adam Ratzman (adamint) wants to merge 1 commit into
microsoft:release/13.4from
adamint:backport/pr-17297-to-release/13.4
Closed

[release/13.4] Add Aspire CLI npm package release integration#17733
Adam Ratzman (adamint) wants to merge 1 commit into
microsoft:release/13.4from
adamint:backport/pr-17297-to-release/13.4

Conversation

@adamint

@adamint Adam Ratzman (adamint) commented May 30, 2026

Copy link
Copy Markdown
Member

Backport of #17297 to release/13.4

/cc Adam Ratzman (@adamint)

Customer Impact

Completes the production path for shipping the Aspire CLI through npm (@microsoft/aspire-cli pointer package plus the RID-specific packages like @microsoft/aspire-cli-linux-x64). Without it, 13.4 can't distribute the CLI to npm users, and anyone who did install via npm gets no upgrade guidance from aspire update. It's a net-new distribution channel — nothing changes for users who get the CLI any other way.

Testing

Built Aspire.Cli against release/13.4 (clean) and ran the affected suites locally — 76 CLI tests (npm detection + update command) and 33 infra tests (npm package + release pipeline) all pass. The end-to-end ESRP/MicroBuild npm publish only runs at release time, so it hasn't been exercised from this branch.

Risk

Medium. The runtime CLI change is small and well-tested (npm install detection + an update message). The bulk is release/packaging infra (AzDO pipeline YAML + packaging/verification scripts) and the npm publish path, which only runs during the official ship pipeline and is gated behind ESRP. The backport also pulls in the extension Corepack build migration (#17630) it depends on. Risk to already-shipping bits is low.

Regression?

No — this is net-new functionality, not a fix to something that regressed in 13.4.

Merge conflicts resolved

The auto /backport failed on conflicts, so this is manual. Conflicts were only in the extension build files (extension/Extension.proj, build.ps1, build.sh) — I took the PR's Corepack flow, since the PR also brings the Corepack bootstrap infra (install-corepack.yml, prepareCorepackYarn.mjs, corepack-version.txt) that 13.4 didn't have yet, and leaving those files on plain yarn would've been inconsistent. release/13.4's own divergence was kept where it didn't conflict (extension version stays 1.0.9; the aspireCliChannelOverride plumbing from #17527 stays, with the PR's NodeTool + npm-verify steps on top). Verified the 15 core npm files are byte-identical to the source PR head, so nothing was dropped.

Backport of microsoft#17297 to release/13.4.

Conflicts resolved in extension/Extension.proj, extension/build.ps1, and
extension/build.sh by taking the PR's Corepack-based build flow, since the
PR also adds the Corepack bootstrap infrastructure (install-corepack.yml,
prepareCorepackYarn.mjs, corepack-version.txt) that release/13.4 lacked.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17733

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17733"

@adamint

Copy link
Copy Markdown
Member Author

Closing this backport for now — will revisit after the fixes from the adversarial review land on the source PR #17297. Reopening/redoing the backport once #17297 is finalized.

@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 13.4 milestone May 30, 2026
@adamint
Adam Ratzman (adamint) removed the request for review from Copilot May 30, 2026 19:07
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant