Improve dashboard summary log formatting - #17595
Conversation
- Indent URL lines with 6 spaces and '- ' prefix so they align with the standard log output indentation - Move container warning to a separate log message with clearer text - Update tests to match new format
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17595Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17595" |
There was a problem hiding this comment.
Pull request overview
Improves the dashboard summary log output by making URL lines easier to scan and separating the container warning into its own log entry.
Changes:
- Adds indented bullet formatting for dashboard and OTLP URL lines.
- Emits the container access guidance as a separate information log.
- Updates
LoggingHelpersTestsexpectations for the new summary format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Shared/LoggingHelpers.cs |
Updates dashboard summary log formatting and container warning emission. |
tests/Aspire.Dashboard.Tests/LoggingHelpersTests.cs |
Adjusts unit test assertions for the new log output format. |
| { | ||
| templateBuilder.Append('\n'); | ||
| templateBuilder.Append("URLs may need changes depending on how network access to the container is configured.").Append('\n'); | ||
| logger.LogInformation("Dashboard is running in a container. Access the dashboard from the host using port forwarding."); |
There was a problem hiding this comment.
Fixed in commit ac6b0f4 → updated FrontendBrowserTokenAuthTests.LogOutput_InContainer_LoginLinkContainerMessage to assert the new standalone container log message instead of looking for the old text inside the summary log.
|
❌ CLI E2E Tests failed — 106 passed, 1 failed, 2 unknown (commit ❌ Failed Tests
View all recordings
📹 Recordings uploaded automatically from CI run #26572290695 |
…er log message Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
|
/backport to release/13.4 |
|
Started backporting to |
|
✅ No documentation update needed. docs_optional → No signals triggered ( |
Description
Improves the dashboard summary log output by making URL lines easier to scan and separating the container warning into its own log entry.
" - "prefix) for dashboard and OTLP URL lines to align with .NET console logger indentationLogInformationcall instead of appending it to the summary templateLoggingHelpersTestsexpectations for the new summary formatFrontendBrowserTokenAuthTests.LogOutput_InContainer_LoginLinkContainerMessageto assert the new standalone container log messageChecklist
<remarks />and<code />elements on your triple slash comments?