-
Notifications
You must be signed in to change notification settings - Fork 922
Update Foundry hosted agent builder APIs #17545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
9085ee7
8957ea8
3890b43
c821b38
f572c46
cae8e89
869dbab
bba95a0
f5cb7a2
ac68738
90fa06e
888b627
30430d9
4ef5764
c9f48bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,10 @@ public static ApplicationModel.IResourceBuilder<T> WithRoleAssignments<T>(this A | |
|
|
||
| public static partial class HostedAgentResourceBuilderExtensions | ||
| { | ||
| [AspireExport] | ||
| public static ApplicationModel.IResourceBuilder<T> AsHostedAgent<T>(this ApplicationModel.IResourceBuilder<T> builder) | ||
| where T : ApplicationModel.IResourceWithEndpoints, ApplicationModel.IResourceWithEnvironment, ApplicationModel.IComputeResource { throw null; } | ||
|
|
||
| [AspireExport("withComputeEnvironmentExecutable", MethodName = "withComputeEnvironment")] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should have been renamed to prevent a conflict with the standard one
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was changed, this is the api file ... I don't think this should have been merged @davidfowl ? |
||
| public static ApplicationModel.IResourceBuilder<T> WithComputeEnvironment<T>(this ApplicationModel.IResourceBuilder<T> builder, ApplicationModel.IResourceBuilder<Foundry.AzureCognitiveServicesProjectResource>? project = null, System.Action<Foundry.HostedAgentConfiguration>? configure = null) | ||
| where T : ApplicationModel.IResourceWithEndpoints, ApplicationModel.IResourceWithEnvironment, ApplicationModel.IComputeResource { throw null; } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this line is new, it should be removed actually, or at least not added, the method doesn't exist anymore. Is that a merge conflict resolution error?