Bump Microsoft.AI.Foundry.Local 0.3.0 -> 1.1.0 (needs API migration) - #17514
Closed
Jose Perez Rodriguez (joperezr) wants to merge 1 commit into
Closed
Bump Microsoft.AI.Foundry.Local 0.3.0 -> 1.1.0 (needs API migration)#17514Jose Perez Rodriguez (joperezr) wants to merge 1 commit into
Jose Perez Rodriguez (joperezr) wants to merge 1 commit into
Conversation
This bump intentionally does not build. Microsoft.AI.Foundry.Local 1.1.0 is a complete API redesign and src/Aspire.Hosting.Foundry needs to be migrated before this can land. Tracking it here as a draft so we have a single place to coordinate the migration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17514Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17514" |
Contributor
|
replaced by #17889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Draft — does not build. Posting this PR to coordinate the migration work. Splitting it out of #17056 so the rest of the deferred dep bumps can land.
What's here
A single one-line bump in
Directory.Packages.props:Why this needs a focused PR
Microsoft.AI.Foundry.Local 1.1.0is a complete API redesign, not an additive release. The wholeFoundryLocalManagerpattern changes:FoundryLocalManagervia DI)FoundryLocalManager.Instance,CreateAsync)manager.IsServiceRunning(sync property)manager.StartServiceAsync(ct)StartWebServiceAsyncwithUrlspropertymanager.Endpoint(property)Urls[0](after web service start)manager.ApiKeymanager.ListLoadedModelsAsync(ct)GetCatalogAsync()→Catalog.GetModelAsync()manager.DownloadModelWithProgressAsync(model, ct)model.DownloadAsync()manager.LoadModelAsync(modelId, ct)model.LoadAsync()Files that need migrating
src/Aspire.Hosting.Foundry/FoundryLocalHealthCheck.cs—manager.IsServiceRunningsrc/Aspire.Hosting.Foundry/LocalModelHealthCheck.cs—manager.ListLoadedModelsAsyncsrc/Aspire.Hosting.Foundry/FoundryExtensions.cs—ApiKey,StartServiceAsync,Endpoint,DownloadModelWithProgressAsync,LoadModelAsync(8 call sites)AddFoundryLocalwill likely change (singleton vs scoped, no longer registering the manager as a service)FoundryLocalManageris nowIDisposablewith explicitCreateAsync/Disposeand singleton ownershipWhy I'm not just doing it
The migration is large enough to deserve product judgement (DI shape, lifecycle, behavior in the AppHost) rather than a mechanical port. Tagging Tommaso Stocchi (@tommasodotNET) and Sébastien Ros (@sebastienros) — you've been closest to the Foundry hosting code recently; can you take a look at how you'd like to adapt this?
The latest SDK README is helpful here: https://www.nuget.org/packages/Microsoft.AI.Foundry.Local/1.1.0
Related