Align TypeScript validation with package manager markers - #17419
Merged
Sébastien Ros (sebastienros) merged 1 commit intoMay 25, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17419Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17419" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript polyglot validation workflow to honor per-fixture package manager markers (via packageManager and lock/config marker files) instead of always running npm install/npx tsc. It adds dedicated TypeScript validation fixtures for npm, pnpm, Yarn 4+, and Bun, and updates the TypeScript validation container image to include the necessary package managers.
Changes:
- Update
test-typescript-playground.shto detect the intended package manager per fixture and run the matching install + typecheck commands. - Add dedicated TypeScript validation AppHosts/fixtures for npm, pnpm, Yarn 4+, and Bun (including their lock/config marker files).
- Update
Dockerfile.typescriptto enable Corepack-managed pnpm/Yarn and install Bun so CI can validate all new fixtures.
Reviewed changes
Copilot reviewed 19 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Yarn/TypeScript/yarn.lock | Adds Yarn 4+ lockfile marker for the Yarn validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Yarn/TypeScript/tsconfig.json | TypeScript compiler configuration for the Yarn validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Yarn/TypeScript/package.json | Defines Yarn fixture dependencies and packageManager marker. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Yarn/TypeScript/aspire.config.json | Configures the Yarn TypeScript AppHost for aspire restore. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Yarn/TypeScript/apphost.mts | Minimal Yarn-marked TypeScript AppHost used for validation. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Yarn/TypeScript/.yarnrc.yml | Adds Yarn config marker for the Yarn validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Pnpm/TypeScript/tsconfig.json | TypeScript compiler configuration for the pnpm validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Pnpm/TypeScript/pnpm-lock.yaml | Adds pnpm lockfile marker for the pnpm validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Pnpm/TypeScript/package.json | Defines pnpm fixture dependencies and packageManager marker. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Pnpm/TypeScript/aspire.config.json | Configures the pnpm TypeScript AppHost for aspire restore. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Pnpm/TypeScript/apphost.mts | Minimal pnpm-marked TypeScript AppHost used for validation. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Npm/TypeScript/tsconfig.json | TypeScript compiler configuration for the npm validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Npm/TypeScript/package.json | Defines npm fixture dependencies and packageManager marker. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Npm/TypeScript/package-lock.json | Adds npm lockfile marker for the npm validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Npm/TypeScript/aspire.config.json | Configures the npm TypeScript AppHost for aspire restore. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Npm/TypeScript/apphost.mts | Minimal npm-marked TypeScript AppHost used for validation. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Bun/TypeScript/tsconfig.json | TypeScript compiler configuration for the Bun validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Bun/TypeScript/package.json | Defines Bun fixture dependencies and packageManager marker. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Bun/TypeScript/bun.lock | Adds Bun lockfile marker for the Bun validation fixture. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Bun/TypeScript/aspire.config.json | Configures the Bun TypeScript AppHost for aspire restore. |
| tests/PolyglotAppHosts/TypeScript.PackageManagers.Bun/TypeScript/apphost.mts | Minimal Bun-marked TypeScript AppHost used for validation. |
| .github/workflows/polyglot-validation/test-typescript-playground.sh | Resolves package manager markers per fixture and runs matching install/typecheck commands. |
| .github/workflows/polyglot-validation/Dockerfile.typescript | Ensures pnpm/Yarn (Corepack) and Bun are available in the validation image. |
Files not reviewed (2)
- tests/PolyglotAppHosts/TypeScript.PackageManagers.Npm/TypeScript/package-lock.json: Language not supported
- tests/PolyglotAppHosts/TypeScript.PackageManagers.Pnpm/TypeScript/pnpm-lock.yaml: Language not supported
Contributor
|
❓ CLI E2E Tests unknown — 96 passed, 0 failed, 5 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26344784986 |
Sébastien Ros (sebastienros)
requested review from
David Pine (IEvangelist) and
David Fowler (davidfowl)
May 24, 2026 00:02
David Fowler (davidfowl)
approved these changes
May 24, 2026
Contributor
|
✅ No documentation update needed. docs_optional → No triggered signals ( All 23 changed files are under |
Ankit Jain (radical)
added a commit
that referenced
this pull request
Jun 6, 2026
Replayed the 161 PRs merged to main between 2026-05-23 and 2026-06-06
through the audit selector. v1 (the prior file) resolved 89/161 PRs to
'selective' and dropped 26/161 to 'fallback_unmatched' (any unmatched
file forces RunAll). After this change all 161 PRs classify cleanly:
18 skip, 32 trigger_all, 111 selective, 0 fallback.
Additions:
* ignorePaths — files that never need a test gate but were forcing
fallback today: .vscode/**, .mcp.json, localhive.{sh,ps1},
.github/{extensions,policies,aw}/**, .agents/** (CLI agent skill
content, consumed only by humans/agents), eng/scripts/debug-*.{sh,ps1}
(developer-loop helpers), eng/scripts/cli-starter-validation*.ps1
(consumed by the always-on cli_starter_validation_windows job, which
isn't conditional-selector-gated).
* sourceToTestMappings — scripts and infra files that have a specific
test home but weren't wired up: eng/Publishing.props,
eng/Signing.props, eng/scripts/{pack,stage,verify,validate}-cli-*
and tools/TypeScriptApiCompat/** all map to Infrastructure.Tests
(its Pipelines/ and PowerShellScripts/ folders test these scripts).
eng/scripts/get-aspire-cli{,-pr}.{sh,ps1}, eng/scripts/verify-cli-archive.ps1,
eng/homebrew/** and eng/winget/** map to Aspire.Acquisition.Tests
(the script-suite that exercises them). eng/scripts/update-aspire-
skills-bundle.ps1 + verify-aspire-skills-bundle.ps1 map to
Aspire.Cli.Tests (AspireSkillsBundleTests). Two self-mappings for
tests directories without a 'tests/Aspire.*.Tests/**' shape:
tests/Infrastructure.Tests/** and
tests/Aspire.Hosting.CodeGeneration.TypeScript.JsTests/**.
* polyglot.triggerPaths — expanded beyond the workflow file itself to
cover the polyglot fixture tree (tests/PolyglotAppHosts/**) and the
per-language Aspire.Hosting.{JavaScript,TypeScript,Python,Go,Java,Rust}
+ CodeGeneration* projects. Without these, polyglot-impacting PRs
(#17545, #17499, #17419, #17400, #17382) all fell into RunAll.
Local verification: 251 TestSelector/PowerShellScripts/ConditionalSelection
tests still pass. The CI-trigger-pattern coverage test (which loads this
file from disk) is unchanged because we only added to ignorePaths and
sourceToTestMappings — no existing entries were removed or narrowed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TypeScript polyglot validation currently installs and type-checks every checked-in AppHost with npm, which means the package-manager marker behavior used by TypeScript AppHosts is not covered by the validation workflow.
This updates the TypeScript polyglot validation script to resolve the intended package manager from each fixture's markers and run the matching install and type-check commands. It also adds dedicated TypeScript validation AppHosts for npm, pnpm, Yarn 4, and Bun so marker-based behavior is covered without changing the existing integration-specific fixtures.
The TypeScript validation image now enables Corepack-managed pnpm/Yarn and installs Bun so the new dedicated fixtures can run in CI.
Validation:
bash -n .github/workflows/polyglot-validation/test-typescript-playground.shpackage.json,aspire.config.json, andtsconfig.jsonfilesdocker build -f .github/workflows/polyglot-validation/Dockerfile.typescript -t polyglot-typescript-validation-test .github/workflows/polyglot-validationThe full local
aspire restorepass was blocked by an existingAspire.DashboardIDE0200 analyzer error while building the generated AppHost server.Fixes: #17034
Checklist
<remarks />and<code />elements on your triple slash comments?