Skip to content

Normalize App Service Application Insights Bicep identifiers #16539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eric Erhardt (eerhardt) merged 4 commits into from
Apr 29, 2026
Merged

Normalize App Service Application Insights Bicep identifiers #16539

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
138d042
Initial plan
Copilot Apr 28, 2026
4ebe418
Normalize app service app insights bicep identifiers
Copilot Apr 29, 2026
ea186e2
Preserve app insights bicep suffix separators
Copilot Apr 29, 2026
6823410
Address PR feedback
eerhardt Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public static IResourceBuilder<AzureAppServiceEnvironmentResource> AddAzureAppSe
else
{
// Create Log Analytics workspace
var logAnalyticsWorkspace = new OperationalInsightsWorkspace(prefix + "_law")
var logAnalyticsWorkspace = new OperationalInsightsWorkspace(Infrastructure.NormalizeBicepIdentifier($"{prefix}_law"))
Comment thread
eerhardt marked this conversation as resolved.
Outdated
Comment thread
eerhardt marked this conversation as resolved.
Outdated
{
Sku = new OperationalInsightsWorkspaceSku()
{
Expand All @@ -217,7 +217,7 @@ public static IResourceBuilder<AzureAppServiceEnvironmentResource> AddAzureAppSe
infra.Add(logAnalyticsWorkspace);

// Create Application Insights resource linked to the Log Analytics workspace
applicationInsights = new ApplicationInsightsComponent(prefix + "_ai")
applicationInsights = new ApplicationInsightsComponent(Infrastructure.NormalizeBicepIdentifier($"{prefix}_ai"))
Comment thread
eerhardt marked this conversation as resolved.
Outdated
Comment thread
eerhardt marked this conversation as resolved.
Outdated
{
ApplicationType = ApplicationInsightsApplicationType.Web,
Kind = "web",
Expand Down
21 changes: 21 additions & 0 deletions tests/Aspire.Hosting.Azure.Tests/AzureAppServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,27 @@ await Verify(manifest.ToString(), "json")
.AppendContentAsFile(bicep, "bicep");
}

[Fact]
public async Task AddAppServiceWithApplicationInsightsNormalizesBicepIdentifiers()
{
var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish);

builder.AddAzureAppServiceEnvironment("env-1").WithAzureApplicationInsights();

using var app = builder.Build();

await ExecuteBeforeStartHooksAsync(app, default);

var model = app.Services.GetRequiredService<DistributedApplicationModel>();

var environment = Assert.Single(model.Resources.OfType<AzureAppServiceEnvironmentResource>());

var (_, bicep) = await GetManifestWithBicep(environment);

Assert.Contains("resource env_1_law ", bicep);
Comment thread
eerhardt marked this conversation as resolved.
Outdated
Assert.Contains("resource env_1_ai ", bicep);
Comment thread
eerhardt marked this conversation as resolved.
Outdated
}

[Fact]
public async Task AddAppServiceWithApplicationInsightsLocationParam()
{
Expand Down
Loading