Bump branding version to 13.2.3 - #16181
Conversation
Agent-Logs-Url: https://github.com/microsoft/aspire/sessions/42367a1d-b584-439d-a6e1-5cde4d83ea53 Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Bumps the repository’s branding/package versions from 13.2.2 to 13.2.3 to align repo testing and Helix test package pinning with the post-ship patch release.
Changes:
- Updated repo patch version to 13.2.3.
- Bumped Aspire.AppHost.Sdk import versions used by out-of-repo test runs.
- Updated hardcoded Aspire package versions in Helix test package props to 13.2.3.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/Versions.props | Patch version bump to 13.2.3. |
| tests/Shared/RepoTesting/Aspire.RepoTesting.targets | Updates Aspire.AppHost.Sdk import versions to 13.2.3 for repo-testing. |
| tests/Shared/RepoTesting/Directory.Packages.Helix.props | Pins Aspire package versions to 13.2.3 for Helix runs. |
| <PackageVersion Include="Aspire.Azure.Security.KeyVault" Version="13.2.3" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="13.2.3" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Queues" Version="13.2.3" /> | ||
| <PackageVersion Include="Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL" Version="13.2.3" /> |
There was a problem hiding this comment.
These two PackageVersion entries appear to target the same package ID (Aspire.Npgsql.EntityFrameworkCore.PostgreSQL), but one line uses Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL. If the Aspire.Azure.* ID is not a real package (or was renamed), this will silently pin a non-existent/unused ID and make updates error-prone. Recommend verifying the correct package ID and removing/renaming the incorrect entry so there is exactly one authoritative PackageVersion for this dependency.
| <PackageVersion Include="Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL" Version="13.2.3" /> | |
| <PackageVersion Include="Aspire.Npgsql.EntityFrameworkCore.PostgreSQL" Version="13.2.3" /> |
| <PackageVersion Include="Aspire.MySqlConnector" Version="13.2.3" /> | ||
| <PackageVersion Include="Aspire.NATS.Net" Version="13.2.3" /> | ||
| <PackageVersion Include="Aspire.Npgsql" Version="13.2.3" /> | ||
| <PackageVersion Include="Aspire.Npgsql.EntityFrameworkCore.PostgreSQL" Version="13.2.3" /> |
There was a problem hiding this comment.
These two PackageVersion entries appear to target the same package ID (Aspire.Npgsql.EntityFrameworkCore.PostgreSQL), but one line uses Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL. If the Aspire.Azure.* ID is not a real package (or was renamed), this will silently pin a non-existent/unused ID and make updates error-prone. Recommend verifying the correct package ID and removing/renaming the incorrect entry so there is exactly one authoritative PackageVersion for this dependency.
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="13.2.3" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | ||
|
|
||
| <PropertyGroup> |
There was a problem hiding this comment.
The Aspire.AppHost.Sdk version is duplicated in two Import statements, which increases the chance of future mismatches. Consider defining a single property in this file (e.g., <AspireAppHostSdkVersion>13.2.3</AspireAppHostSdkVersion> or reusing an existing version property if available here) and referencing it from both Import Version attributes so only one value needs updating per bump.
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="13.2.3" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | |
| <PropertyGroup> | |
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="$(AspireAppHostSdkVersion)" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | |
| <PropertyGroup> | |
| <AspireAppHostSdkVersion>13.2.3</AspireAppHostSdkVersion> |
| </PropertyGroup> | ||
|
|
||
| <Import Project="Sdk.targets" Sdk="Aspire.AppHost.Sdk" Version="13.2.2" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | ||
| <Import Project="Sdk.targets" Sdk="Aspire.AppHost.Sdk" Version="13.2.3" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> |
There was a problem hiding this comment.
The Aspire.AppHost.Sdk version is duplicated in two Import statements, which increases the chance of future mismatches. Consider defining a single property in this file (e.g., <AspireAppHostSdkVersion>13.2.3</AspireAppHostSdkVersion> or reusing an existing version property if available here) and referencing it from both Import Version attributes so only one value needs updating per bump.
Description
Post-ship version bump from 13.2.2 → 13.2.3, following the same pattern as #15754.
eng/Versions.props:PatchVersion2 → 3tests/Shared/RepoTesting/Aspire.RepoTesting.targets:Aspire.AppHost.Sdkversion in bothSdk.propsandSdk.targetsimportstests/Shared/RepoTesting/Directory.Packages.Helix.props: All hardcoded package versionsChecklist