[Automated] Update API Surface Area - #16042
Closed
aspire-repo-bot[bot] wants to merge 2 commits into
Closed
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16042Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16042" |
Contributor
|
🎬 CLI E2E Test Recordings — 53 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24253728286 |
github-actions
Bot
force-pushed
the
update-api-diffs
branch
7 times, most recently
from
April 17, 2026 16:45
bdb40f1 to
57043db
Compare
github-actions
Bot
force-pushed
the
update-api-diffs
branch
8 times, most recently
from
April 25, 2026 16:35
e9ecff7 to
48e97b9
Compare
github-actions
Bot
force-pushed
the
update-api-diffs
branch
3 times, most recently
from
April 28, 2026 17:03
9886e9c to
b3b7dbb
Compare
github-actions
Bot
force-pushed
the
update-api-diffs
branch
from
April 29, 2026 17:01
b3b7dbb to
8aabfc5
Compare
Eric Erhardt (eerhardt)
left a comment
Member
There was a problem hiding this comment.
API review findings — see inline comments for details.
Member
API Review Summary1 error, 1 warning, 0 info across 2 files. Top areas of concern:
Each finding is posted as a separate inline comment for discussion. |
…6566) * [release/13.3] Stabilizing builds in preparation for 13.3 release - Flip StabilizePackageVersion default to true in eng/Versions.props - Drop the compute_version_suffix step from ci.yml so PR builds use the stabilized version - Pin Aspire.AppHost.Sdk import to 13.3.0 in RepoTesting.targets - Pin all stabilizable Aspire packages to 13.3.0 in Directory.Packages.Helix.props (packages whose csproj sets SuppressFinalPackageVersion=true keep $(PackageVersion)) - Skip preview-only AppHosts (Kusto, Foundry, Keycloak, Kubernetes, Maui) in the TypeScript polyglot validation script (see #15335) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * [release/13.3] Skip tests blocked by suppressed-package stabilization gap Two test buckets cannot run on a stabilized branch because they exercise NuGet restore against Aspire.Hosting.* packages that have SuppressFinalPackageVersion=true and therefore only ship as prerelease (e.g. 13.3.0-dev.<sha>) — but the stabilized build asks for >= 13.3.0 stable. Polyglot SDK Validation: - Add 'Aspire.Hosting' to the skip list in test-typescript-playground.sh (it transitively depends on Aspire.Hosting.Azure.Kubernetes via aspire.config.json). - Apply the same skip block to test-python-playground.sh and test-java-playground.sh (the 13.2 PR only updated the TypeScript script). Cli.EndToEnd-KubernetesDeploy* (11 files): - Mark each [Fact] with [ActiveIssue(#15335)]. The proper fix is the dynamic version computation tracked by #15335 (PR #15681). When that lands the ActiveIssue tags can be removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
force-pushed
the
update-api-diffs
branch
from
April 30, 2026 17:00
8aabfc5 to
c23326c
Compare
github-actions
Bot
requested a review
from Ankit Jain (radical)
as a code owner
April 30, 2026 17:00
Member
|
Closing in favor of #16602 (since we snapped and that one is targeting release branch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.