Skip to content

Revert "Add networkIsolationPolicy to 1ES pipeline templates for SFI-ES4.2.4 compliance" #15193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radical merged 1 commit into from
Mar 12, 2026
Merged

Revert "Add networkIsolationPolicy to 1ES pipeline templates for SFI-ES4.2.4 compliance" #15193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions eng/pipelines/azure-pipelines-unofficial.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ resources:
extends:
template: v1/1ES.Unofficial.PipelineTemplate.yml@1ESPipelineTemplates
parameters:
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is described as a temporary revert, consider adding an inline comment/TODO near parameters: documenting the rollback reason (winget break) and a tracking link (issue/PR) for re-introducing the policy after 13.2. This makes it less likely the compliance setting is forgotten and helps future maintainers understand why the policy is absent.

Suggested change
parameters:
parameters:
# TODO: Temporary rollback of Roslyn auto-enable ruleset due to winget break.
# Re-enable after 13.2 once the policy can be safely applied.
# Tracking: ISSUE-XXXX (replace with real issue/PR link).

Copilot uses AI. Check for mistakes.
settings:
networkIsolationPolicy: Permissive,CFSClean2
featureFlags:
autoEnablePREfastWithNewRuleset: false
autoEnableRoslynWithNewRuleset: false
Expand Down
2 changes: 0 additions & 2 deletions eng/pipelines/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ resources:
extends:
template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
parameters:
settings:
networkIsolationPolicy: Permissive,CFSClean2
featureFlags:
autoEnablePREfastWithNewRuleset: false
autoEnableRoslynWithNewRuleset: false
Comment on lines 105 to 110
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing networkIsolationPolicy entirely likely reverts the pipeline to a less-controlled default and may re-open the SFI-ES4.2.4 / s360 findings that the reverted PR was addressing. If the issue is specifically winget access, consider re-introducing networkIsolationPolicy with a narrower exception (e.g., avoid the specific enforcement mode that breaks winget, or isolate the winget acquisition by using a pre-baked image/internal artifact so the overall pipeline can keep the stricter policy).

Copilot uses AI. Check for mistakes.
Expand Down
Loading