Change Analyzer references to be consistent#15176
Merged
eerhardt merged 4 commits intomicrosoft:release/13.2from Mar 12, 2026
Merged
Change Analyzer references to be consistent#15176eerhardt merged 4 commits intomicrosoft:release/13.2from
eerhardt merged 4 commits intomicrosoft:release/13.2from
Conversation
We have 2 analyzers, but we build and pack them differently. We should use the same pattern.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15176Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15176" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make how Aspire.Hosting.Integration.Analyzers is built/packed consistent with the pattern used elsewhere by switching from an explicit MSBuild Build invocation to a ProjectReference-driven build graph.
Changes:
- Adds a
ProjectReferencetoAspire.Hosting.Integration.Analyzers.csprojwithReferenceOutputAssembly="false"to ensure it is built. - Simplifies the pack hook target by removing the explicit
MSBuild ... Targets="Build"call and only usingGetTargetPathto locate the analyzer output for packaging.
This was referenced Mar 12, 2026
Remove unnecessary MSBuild attributes from the analyzer ProjectReference. Introduce SkipAspireIntegrationAnalyzersReference MSBuild property to control automatic referencing of Aspire.Hosting.Integration.Analyzers. Replace hardcoded project exclusions with property-based logic for improved maintainability. Set the property in AppHost and RemoteHost projects, and for Roslyn components.
…M image The unofficial pipeline was still using the now-removed windows.vs2022preview.amd64 image, causing the build stage to be skipped. Updated to match the official pipeline's image. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The unofficial pipeline was missing the Node.js, yarn, and vsce installation steps that the official pipeline has before calling the BuildAndTest template. Since BuildAndTest uses /p:BuildExtension=true, the VS Code extension build requires these tools. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joperezr
approved these changes
Mar 12, 2026
Member
|
Thanks Eric! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have 2 analyzers, but we build and pack them differently. We should use the same pattern.