Skip to content

Strip build metadata from CLI banner version display #15168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidfowl merged 1 commit into from
Mar 12, 2026
+8 −0
Merged

Strip build metadata from CLI banner version display #15168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Aspire.Cli/Interaction/BannerService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ public BannerService(ConsoleEnvironment consoleEnvironment)
public async Task DisplayBannerAsync(CancellationToken cancellationToken = default)
{
var cliVersion = VersionHelper.GetDefaultTemplateVersion();

// Strip build metadata (everything after '+') for display purposes.
var plusIndex = cliVersion.IndexOf('+', StringComparison.Ordinal);
if (plusIndex >= 0)
{
cliVersion = cliVersion[..plusIndex];
}
Comment on lines +55 to +60
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new behavior (stripping build metadata after '+') is user-visible but isn’t covered by an automated regression test. Consider adding coverage that asserts the banner’s version text does not include '+' build metadata (e.g., an E2E banner test that searches for absence of '+' on the version line, or a small unit test around an extracted helper used by BannerService).

Copilot uses AI. Check for mistakes.

var aspireWidth = s_aspireLines[0].TrimEnd().Length;
var welcomeText = RootCommandStrings.BannerWelcomeText;
var versionText = string.Format(CultureInfo.CurrentCulture, RootCommandStrings.BannerVersionFormat, cliVersion);
Expand Down
Loading