Clean up RemoteHost project now that it is included in the Aspire.Managed#15149
Merged
eerhardt merged 1 commit intomicrosoft:release/13.2from Mar 12, 2026
Merged
Clean up RemoteHost project now that it is included in the Aspire.Managed#15149eerhardt merged 1 commit intomicrosoft:release/13.2from
eerhardt merged 1 commit intomicrosoft:release/13.2from
Conversation
…aged These settings are no longer needed.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15149Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15149" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes now-unnecessary build/packaging/debugging settings from the Aspire.Hosting.RemoteHost project after the RemoteHost functionality was incorporated into Aspire.Managed, aiming to simplify local debugging.
Changes:
- Removes the RemoteHost
Program.csentrypoint. - Simplifies
Aspire.Hosting.RemoteHost.csprojby dropping executable/packaging/publish/debug-related properties and marking the project as non-packable. - Adds
Aspire.Managedto the solution.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.RemoteHost/Program.cs | Removes the RemoteHost server entrypoint. |
| src/Aspire.Hosting.RemoteHost/Aspire.Hosting.RemoteHost.csproj | Strips exe/packaging/publish/debug settings; disables packing. |
| Aspire.slnx | Adds the Aspire.Managed project to the solution. |
radical
approved these changes
Mar 12, 2026
Contributor
|
Test in dev mode first |
Member
Author
Tested in dev mode and it appears to work. So does the PR built assets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These settings are no longer needed.
They also make debugging harder than it should be.