Skip to content

Fix failing test after log message updated to reference aka.ms/aspire/devcerts #15043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danegsta merged 2 commits into from
Mar 7, 2026
+3 −10
Merged

Fix failing test after log message updated to reference aka.ms/aspire/devcerts #15043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65b9a00
Initial plan
Copilot Mar 7, 2026
db92275
Fix failing test that was checking for outdated string content after …
Copilot Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions tests/Aspire.Hosting.Tests/Dcp/DcpHostNotificationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,7 @@ public async Task DcpHost_WithUntrustedDeveloperCertificate_ShowsNotificationAnd
var timeProvider = new FakeTimeProvider();
var developerCertificateService = new TestDeveloperCertificateService([certificate], false, true, false, latestCertificateIsUntrusted: true);
var fileSystemService = new FileSystemService(new ConfigurationBuilder().Build());
var appHostDirectory = Path.Combine(Path.GetTempPath(), "aspire-apphost-test");
var configuration = new ConfigurationBuilder()
.AddInMemoryCollection(new Dictionary<string, string?>
{
["AppHost:Directory"] = appHostDirectory
})
.Build();
var configuration = new ConfigurationBuilder().Build();

var dcpHost = new DcpHost(
loggerFactory,
Expand All @@ -162,12 +156,11 @@ public async Task DcpHost_WithUntrustedDeveloperCertificate_ShowsNotificationAnd
var interaction = await interactionService.Interactions.Reader.ReadAsync(cts.Token);

// Assert
var expectedMessage = string.Format(CultureInfo.CurrentCulture, InteractionStrings.DeveloperCertificateNotFullyTrustedMessage, $"'{appHostDirectory}'");
Assert.Equal(InteractionStrings.DeveloperCertificateNotFullyTrustedTitle, interaction.Title);
Assert.Equal(expectedMessage, interaction.Message);
Assert.Equal(InteractionStrings.DeveloperCertificateNotFullyTrustedMessage, interaction.Message);
var notificationOptions = Assert.IsType<NotificationInteractionOptions>(interaction.Options);
Assert.Equal(MessageIntent.Error, notificationOptions.Intent);
Assert.Contains(testSink.Writes, w => w.LogLevel == LogLevel.Warning && w.Message is not null && w.Message.Contains(appHostDirectory, StringComparison.Ordinal));
Assert.Contains(testSink.Writes, w => w.LogLevel == LogLevel.Warning && w.Message is not null && w.Message.Contains("aka.ms/aspire/devcerts", StringComparison.Ordinal));
}

[Fact]
Expand Down
Loading