Hide available features in 'aspire config list' behind --available flag#15017
Hide available features in 'aspire config list' behind --available flag#15017maddymontaquila merged 2 commits intorelease/13.2from
Conversation
The list of available feature flags was scrolling the set configuration off the screen. Now 'aspire config list' shows a hint to use --available, and 'aspire config list --available' shows the full feature list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15017Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15017" |
There was a problem hiding this comment.
Pull request overview
This PR updates aspire config list to avoid overwhelming output by hiding the long “available features” list behind a new --available flag, while still guiding users to discover it.
Changes:
- Added
--availableoption toaspire config listto control whether the full unconfigured feature list is shown. - Default
config listbehavior now shows configuration tables plus an “Available Features” header with a hint to use--available. - Added new localized strings for the hint text and option description across supported CLI localizations.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Cli/Commands/ConfigCommand.cs | Implements --available option and conditional rendering of the available-features section. |
| src/Aspire.Cli/Resources/ConfigCommandStrings.resx | Adds resource entries for the new hint text and option description. |
| src/Aspire.Cli/Resources/ConfigCommandStrings.Designer.cs | Regenerates strongly-typed resource accessors for new strings. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.cs.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.de.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.es.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.fr.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.it.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.ja.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.ko.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.pl.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.pt-BR.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.ru.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.tr.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.zh-Hans.xlf | Adds new trans-units for the hint and option description. |
| src/Aspire.Cli/Resources/xlf/ConfigCommandStrings.zh-Hant.xlf | Adds new trans-units for the hint and option description. |
Files not reviewed (1)
- src/Aspire.Cli/Resources/ConfigCommandStrings.Designer.cs: Language not supported
|
Nice cleanup! A couple of small things:
|
|
One more thing — the Established CLIs overwhelmingly use
I'd suggest |
…ests - Rename --available flag to --all (matches established CLI conventions) - Hoist shared empty line + header above the conditional to reduce duplication - Add tests for both config list paths (hint without --all, details with --all) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@davidfowl addressed all three items — renamed to |
davidfowl
left a comment
There was a problem hiding this comment.
Looks good — all three items addressed cleanly. Thanks Maddy!
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22778109479 |
…5017) * Hide available features in 'aspire config list' behind --available flag The list of available feature flags was scrolling the set configuration off the screen. Now 'aspire config list' shows a hint to use --available, and 'aspire config list --available' shows the full feature list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address PR feedback: rename --available to --all, hoist header, add tests - Rename --available flag to --all (matches established CLI conventions) - Hoist shared empty line + header above the conditional to reduce duplication - Add tests for both config list paths (hint without --all, details with --all) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…crosoft#15017) * Hide available features in 'aspire config list' behind --available flag The list of available feature flags was scrolling the set configuration off the screen. Now 'aspire config list' shows a hint to use --available, and 'aspire config list --available' shows the full feature list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address PR feedback: rename --available to --all, hoist header, add tests - Rename --available flag to --all (matches established CLI conventions) - Hoist shared empty line + header above the conditional to reduce duplication - Add tests for both config list paths (hint without --all, details with --all) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…5017) * Hide available features in 'aspire config list' behind --available flag The list of available feature flags was scrolling the set configuration off the screen. Now 'aspire config list' shows a hint to use --available, and 'aspire config list --available' shows the full feature list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address PR feedback: rename --available to --all, hoist header, add tests - Rename --available flag to --all (matches established CLI conventions) - Hoist shared empty line + header above the conditional to reduce duplication - Add tests for both config list paths (hint without --all, details with --all) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
The list of available feature flags in
aspire config listwas so long it scrolled the actual set configuration off the screen.Changes
--availableoption toaspire config listBefore
aspire config listshowed all unconfigured features, pushing config tables off screen.After
aspire config listshows config tables + hint.aspire config list --availableshows config tables + full feature list.