Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast#14935
Merged
davidfowl merged 2 commits intofix-cli-testfrom Mar 5, 2026
Merged
Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast#14935davidfowl merged 2 commits intofix-cli-testfrom
davidfowl merged 2 commits intofix-cli-testfrom
Conversation
16 tasks
…lFast Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on handling CLI download failures
Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast
Mar 4, 2026
JamesNK
approved these changes
Mar 5, 2026
radical
added a commit
that referenced
this pull request
Mar 5, 2026
* Fail fast when CLI download fails in E2E tests Add WaitForSuccessPromptFailFast to Hex1bTestHelpers that watches for both OK and ERR prompts. When the CLI artifact download fails (e.g. HTTP 502), the test now throws immediately instead of waiting the full 5-minute timeout. Updated InstallAspireCliFromPullRequest, InstallAspireCliVersion, InstallAspireBundleFromPullRequest, and InstallAspireCliRelease to use the new fail-fast method. Fixes #14933 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast (#14935) * Initial plan * Update InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast Co-authored-by: radical <1472+radical@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: radical <1472+radical@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: radical <1472+radical@users.noreply.github.com>
eerhardt
pushed a commit
to eerhardt/aspire
that referenced
this pull request
Mar 7, 2026
* Fail fast when CLI download fails in E2E tests Add WaitForSuccessPromptFailFast to Hex1bTestHelpers that watches for both OK and ERR prompts. When the CLI artifact download fails (e.g. HTTP 502), the test now throws immediately instead of waiting the full 5-minute timeout. Updated InstallAspireCliFromPullRequest, InstallAspireCliVersion, InstallAspireBundleFromPullRequest, and InstallAspireCliRelease to use the new fail-fast method. Fixes microsoft#14933 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast (microsoft#14935) * Initial plan * Update InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast Co-authored-by: radical <1472+radical@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: radical <1472+radical@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot AI
added a commit
that referenced
this pull request
Mar 10, 2026
* Fail fast when CLI download fails in E2E tests Add WaitForSuccessPromptFailFast to Hex1bTestHelpers that watches for both OK and ERR prompts. When the CLI artifact download fails (e.g. HTTP 502), the test now throws immediately instead of waiting the full 5-minute timeout. Updated InstallAspireCliFromPullRequest, InstallAspireCliVersion, InstallAspireBundleFromPullRequest, and InstallAspireCliRelease to use the new fail-fast method. Fixes #14933 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast (#14935) * Initial plan * Update InstallAspireCliFromPullRequest to use WaitForSuccessPromptFailFast Co-authored-by: radical <1472+radical@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: radical <1472+radical@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: radical <1472+radical@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstallAspireCliFromPullRequestwas missed in the original fix (#14934) — it still usedWaitForSuccessPromptdespite downloading from the GitHub API viacurl, making it susceptible to the same HTTP 502 failures described in issue #14933.Description
Changed
WaitForSuccessPrompt→WaitForSuccessPromptFailFastinInstallAspireCliFromPullRequestto match the behavior ofInstallAspireCliReleaseandInstallAspireCliDaily.Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.