-
Notifications
You must be signed in to change notification settings - Fork 953
Restructure CLI resource commands under 'aspire resource' #14918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
David Fowler (davidfowl)
merged 6 commits into
release/13.2
from
jamesnk/command-resource-refactor
Mar 4, 2026
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
63c4655
Restructure CLI resource commands under 'aspire resource'
JamesNK 5dd455c
Detect bare-word args in 'aspire start' and guide users to 'aspire re…
JamesNK 13e4d5d
Remove TreatUnmatchedTokensAsErrors=false from StartCommand
JamesNK 86290a8
Add tests that 'aspire start/stop myresource' fail
JamesNK f0d0759
Restore unmatched token forwarding in StartCommand and add forwarding…
JamesNK 91003d2
Move StartDescription to StartCommandStrings
JamesNK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StartCommand no longer has a positional argument, but it still sets TreatUnmatchedTokensAsErrors=false and forwards all unmatched tokens to the AppHost. This means
aspire start myresourcewill silently passmyresourceto the AppHost instead of failing (or guiding users toaspire resource myresource start), which is a behavioral regression given the CLI restructure described in the PR.