Add polyglot exports for Aspire.Hosting.Azure.SignalR#14900
Merged
sebastienros merged 4 commits intorelease/13.2from Mar 4, 2026
Merged
Add polyglot exports for Aspire.Hosting.Azure.SignalR#14900sebastienros merged 4 commits intorelease/13.2from
sebastienros merged 4 commits intorelease/13.2from
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds polyglot (capability) exports for Aspire.Hosting.Azure.SignalR and introduces a TypeScript validation AppHost playground to exercise the generated SDK surface.
Changes:
- Marked non-polyglot
AddAzureSignalRoverloads to be ignored for exports and added a dedicated polyglot export (addAzureSignalR). - Exported
runAsEmulatorfor polyglot app hosts. - Added a TypeScript ValidationAppHost playground (configs + generated
.modulesSDK) to validate the exported capabilities.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.SignalR/AzureSignalRExtensions.cs | Adds export metadata/ignore attributes and dedicated polyglot export entrypoints. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/tsconfig.json | TypeScript compiler configuration for the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/package.json | Node/TS dependencies and scripts for running/building the validation AppHost. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/apphost.ts | Minimal TS app host that calls the new exported capabilities. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/apphost.run.json | Run profile configuration for the validation host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/transport.ts | JSON-RPC transport + callback/cancellation plumbing used by generated SDK. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/base.ts | Core wrapper types (ResourceBuilderBase, ReferenceExpression, AspireList/Dict). |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/aspire.ts | Generated capability-based TS SDK including addAzureSignalR and runAsEmulator. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/.codegen-hash | Tracks codegen state for the generated .modules output. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.aspire/settings.json | Aspire polyglot host settings referencing TS entrypoint + package mapping. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/base.ts
Show resolved
Hide resolved
...und/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
...und/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
...und/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
...und/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
...und/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/.modules/base.ts
Show resolved
Hide resolved
76 tasks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14900Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14900" |
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22646901861 |
Removed remark about overload availability in polyglot app hosts.
Removed remark about overload availability in polyglot app hosts.
davidfowl
approved these changes
Mar 4, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add polyglot exports for Aspire.Hosting.Azure.SignalR Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Refine AspireExport descriptions for polyglot-azure-signalr Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove polyglot app hosts remark from AddAzureSignalR Removed remark about overload availability in polyglot app hosts. * Remove polyglot app hosts remark from documentation Removed remark about overload availability in polyglot app hosts. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069