Add polyglot exports for Aspire.Hosting.Azure.AppConfiguration#14892
Merged
davidfowl merged 2 commits intorelease/13.2from Mar 4, 2026
Merged
Add polyglot exports for Aspire.Hosting.Azure.AppConfiguration#14892davidfowl merged 2 commits intorelease/13.2from
davidfowl merged 2 commits intorelease/13.2from
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14892Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14892" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds polyglot (ATS/AspireExport) coverage for Aspire.Hosting.Azure.AppConfiguration, including exported capabilities and a TypeScript validation app host.
Changes:
- Added
[AspireExport]attributes for Azure App Configuration resource creation and emulator configuration APIs. - Introduced an ATS-friendly
AzureAppConfigurationRoleenum and an ATS-compatibleWithRoleAssignmentsoverload that maps toAppConfigurationBuiltInRole. - Added a TypeScript polyglot ValidationAppHost (tsconfig/package/apphost + generated
.modulescontent) to validate the exported surface.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.AppConfiguration/AzureAppConfigurationRole.cs | Adds an internal ATS-compatible role enum for polyglot exports. |
| src/Aspire.Hosting.Azure.AppConfiguration/AzureAppConfigurationExtensions.cs | Exports App Configuration APIs and adds ATS-compatible role assignment overload. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/tsconfig.json | Adds TS config for the validation polyglot app host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/package.json | Adds Node/TS dependencies and scripts for validation. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/apphost.ts | Adds a validation app host that exercises the new exports. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/apphost.run.json | Adds run profile settings for local validation. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/transport.ts | Adds the generated ATS transport layer used by the validation app host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/base.ts | Adds generated base types/helpers used by the validation app host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/aspire.ts | Adds generated TS SDK surface that includes the new App Configuration exports. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/.codegen-hash | Records codegen hash for the generated TS modules. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.aspire/settings.json | Declares the TS app host settings and package mapping. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/package-lock.json: Language not supported
...lot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
...lot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
...lot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
...lot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/.modules/transport.ts
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.AppConfiguration/AzureAppConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.AppConfiguration/AzureAppConfigurationRole.cs
Outdated
Show resolved
Hide resolved
76 tasks
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22642603013 |
IEvangelist
approved these changes
Mar 3, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
approved these changes
Mar 4, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add AspireExport coverage for Azure AppConfiguration Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address review feedback for polyglot-azure-appconfiguration Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add polyglot AspireExport coverage for Aspire.Hosting.Azure.AppConfiguration.
Related to #14069.
Validation:
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: