-
Notifications
You must be signed in to change notification settings - Fork 923
Add project reference support for polyglot apphost integrations #14821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b5fda4a
Add project reference support for polyglot apphost integrations
davidfowl b5ae562
Remove GetAllPackages, migrate tests to GetIntegrationReferences
davidfowl 769da44
Use single dotnet publish for PrebuiltAppHostServer integration resol…
davidfowl b3d5a35
Only use dotnet publish when project references are present
davidfowl ea28690
Use dotnet build with CopyLocalLockFileAssemblies instead of publish
davidfowl 7da892d
Add SDK check for project refs and isolate from parent MSBuild imports
davidfowl 32c0df9
Remove DotNetBasedAppHostServerProject casts from SDK commands
davidfowl 66a3ab9
Use CLI version for SDK commands, let project deps resolve transitively
davidfowl c7753cd
Add unit tests for IntegrationReference and synthetic project generation
davidfowl 25aa82a
Add E2E test for project reference integration support
davidfowl 5a49b29
Simplify E2E test: use ExecuteCallback for file creation
davidfowl 5778892
Address PR review feedback
davidfowl d2b702e
Use using directive for System.Xml.Linq
davidfowl 8317809
Improve project reference E2E test with describe/wait verification
davidfowl 26b23bc
Fix E2E test: use redis image instead of nonexistent myservice
davidfowl 35ba2cc
Fix E2E test: correct project reference path and force codegen regene…
davidfowl babcde2
Fix: write nuget.config with channel sources for project ref builds
davidfowl 431f132
Fix CheckAsync tuple deconstruction after release/13.2 rebase
davidfowl 60ae7b9
Add build output logging for integration project failures
davidfowl b213eca
Dump child log on E2E test failure for CI debugging
davidfowl c31efdf
Fix: use RestoreConfigFile to ensure project references resolve from …
davidfowl 7754985
Fix E2E test: write nuget.config in workspace for project reference r…
davidfowl 5202e22
Address JamesNK review feedback
davidfowl 1903c3d
Use RestoreAdditionalProjectSources in DotNetBasedAppHostServerProject
davidfowl 3af7787
Address JamesNK and sebastienros review feedback
davidfowl b682686
Resolve project ref assembly names from MSBuild build output
davidfowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Aspire.Cli.Configuration; | ||
|
|
||
| /// <summary> | ||
| /// Represents a reference to an Aspire hosting integration, which can be either | ||
| /// a NuGet package (with a version) or a local project reference (with a path to a .csproj). | ||
| /// </summary> | ||
| /// <param name="Name">The package or assembly name (e.g., "Aspire.Hosting.Redis").</param> | ||
| /// <param name="Version">The NuGet package version, or null for project references.</param> | ||
| /// <param name="ProjectPath">The absolute path to the .csproj file, or null for NuGet packages.</param> | ||
| internal sealed record IntegrationReference(string Name, string? Version, string? ProjectPath) | ||
| { | ||
| /// <summary> | ||
| /// Returns true if this is a project reference (has a .csproj path). | ||
| /// </summary> | ||
| public bool IsProjectReference => ProjectPath is not null; | ||
|
|
||
| /// <summary> | ||
| /// Returns true if this is a NuGet package reference (has a version). | ||
| /// </summary> | ||
| public bool IsPackageReference => Version is not null; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.