-
Notifications
You must be signed in to change notification settings - Fork 931
Support debugging browser and JavaScript apps in 13.2 #14686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
d9fab7d
187d5d6
fab154b
c36046f
f5733de
79527df
1a387f4
2f47aa6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,6 +128,9 @@ export class AspireTerminalProvider implements vscode.Disposable { | |
| const env: any = { | ||
| ...process.env, | ||
|
|
||
| // IDE identification for Aspire debug features | ||
| ASPIRE_IDE: 'vscode', | ||
|
|
||
| // Extension connection information | ||
| ASPIRE_EXTENSION_ENDPOINT: this.rpcServerConnectionInfo.address, | ||
| ASPIRE_EXTENSION_TOKEN: this.rpcServerConnectionInfo.token, | ||
|
|
@@ -150,6 +153,7 @@ export class AspireTerminalProvider implements vscode.Disposable { | |
| env.ASPIRE_EXTENSION_DEBUG_RUN_MODE = noDebug === false ? "Debug" : "NoDebug"; | ||
| env.DEBUG_SESSION_INFO = JSON.stringify(getRunSessionInfo()); | ||
| env.ASPIRE_EXTENSION_CAPABILITIES = getSupportedCapabilities().join(','); | ||
| env.ASPIRE_EXTENSION_WORKSPACE_ROOT = vscode.workspace.workspaceFolders?.[0]?.uri.fsPath; | ||
|
|
||
|
Comment on lines
168
to
171
|
||
| // if DCP debug logging is enabled, set DCP-specific logging environment variables | ||
| const dcpDebugLoggingEnabled = vscode.workspace.getConfiguration('aspire').get<boolean>('enableAspireDcpDebugLogging', false); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This throws
invalidLaunchConfiguration(JSON.stringify(configuration))whenconfigurationis undefined. WithstrictTS settings,JSON.stringify(undefined)isundefined(not a string), so this won’t type-check and also loses the actual failing input. Pass a definite string (e.g., details aboutlaunchConfig/launchConfig.type) instead.