-
Notifications
You must be signed in to change notification settings - Fork 939
Partially fix quarantined test: Update stale snapshot for DeployAsync_WithMultipleComputeEnvironments_Works #14551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
30223a7
Initial plan
Copilot d8e6665
Update snapshot for DeployAsync_WithMultipleComputeEnvironments_Works…
Copilot be69312
Remove quarantine attribute from DeployAsync_WithMultipleComputeEnvir…
Copilot 72b9063
Restore quarantine attribute - step="deploy" case still fails
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot do not remove the attribute though, since the
step: "deploy"case still fails with a different error. but confirm that in any case. We should not close the corresponding issue either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed - the
step: "deploy"case still fails with the same ACR login error. Only one registry (acaregistry.azurecr.io) is being logged into when both (acaregistry.azurecr.io and aasregistry.azurecr.io) are expected. Restored the quarantine attribute in commit 72b9063.The snapshot update only fixed the
step: "diagnostics"case. The underlying ACR login issue for the deploy case remains unresolved.