Skip to content

[release/13.1] Fix Aspire.ProjectTemplates build failure from command line length limits #14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 8 commits into from
Jan 20, 2026
Merged

[release/13.1] Fix Aspire.ProjectTemplates build failure from command line length limits #14009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a6a831c
Initial plan
Copilot Dec 16, 2025
5d4b871
Update replace-text.cs to use System.CommandLine and .rsp file support
Copilot Dec 16, 2025
3905e1f
Improve error handling in replace-text.cs script
Copilot Dec 16, 2025
be3501b
Build replace-text.cs to executable before running to avoid dotnet CL…
Copilot Dec 16, 2025
3f57d1a
Remove accidentally committed test files
Copilot Dec 16, 2025
1ea1e0a
Use dotnet script.cs with -- to avoid CLI expanding .rsp file
Copilot Dec 16, 2025
7d5a2e8
Remove explicit build step for replace-text script
Copilot Dec 16, 2025
3846d05
Fix formatting
DamianEdwards Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions src/Aspire.ProjectTemplates/Aspire.ProjectTemplates.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@
<VersionMajor>$(_VersionBase.Split('.')[0])</VersionMajor>
<VersionMinor>$(_VersionBase.Split('.')[1])</VersionMinor>
<VersionMajorMinor>$(VersionMajor).$(VersionMinor)</VersionMajorMinor>
<_RspFilePath>$(IntermediateOutputPath)replace-text-args.rsp</_RspFilePath>
<_ReplaceTextScriptPath>$(RepoRoot)tools/scripts/replace-text.cs</_ReplaceTextScriptPath>
</PropertyGroup>

<ItemGroup>
Expand Down Expand Up @@ -121,22 +123,25 @@
<Replacements Include="$(OpenTelemetryInstrumentationRuntimeVersion)" />
</ItemGroup>

<PropertyGroup>
<SourcesFilesArgs>&quot;@(SourceFiles, '&quot; &quot;')&quot;</SourcesFilesArgs>
<ReplacementsArgs>&quot;@(Replacements, '&quot; &quot;')&quot;</ReplacementsArgs>
</PropertyGroup>

<!-- Build the .rsp file content as an item group -->
<ItemGroup>
<CommandArgs Include="dotnet" />
<CommandArgs Include="$(RepoRoot)tools/scripts/replace-text.cs" />
<CommandArgs Include="--files" />
<CommandArgs Include="$(SourcesFilesArgs)" />
<!-- Replacement tokens and their values -->
<CommandArgs Include="--replacements" />
<CommandArgs Include="$(ReplacementsArgs)" />
<_RspLines Include="--files" />
<_RspLines Include="@(SourceFiles)" />
Copy link
Member

@joperezr joperezr Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: should these be quoted?

Copy link
Member

@joperezr joperezr Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamianEdwards might be worth to consider this in main

Copy link
Member

@eerhardt eerhardt Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.rsp files are line delimited, so there is no need to quote paths since the whole path is on a single line and the whole line is treated as a single string.

<_RspLines Include="--replacements" />
<_RspLines Include="@(Replacements)" />
</ItemGroup>

<Exec Command="@(CommandArgs, ' ')" WorkingDirectory="$(MSBuildThisFileDirectory)" StandardOutputImportance="Normal" StandardErrorImportance="Normal" />
<!-- Write the .rsp file -->
<WriteLinesToFile File="$(_RspFilePath)"
Lines="@(_RspLines)"
Overwrite="true"
WriteOnlyWhenDifferent="true" />

<!-- Execute the script with the .rsp file, using double dash to pass arguments directly to the script -->
<Exec Command="dotnet &quot;$(_ReplaceTextScriptPath)&quot; -- @&quot;$(_RspFilePath)&quot;"
WorkingDirectory="$(MSBuildThisFileDirectory)"
StandardOutputImportance="Normal"
StandardErrorImportance="Normal" />
</Target>

<!-- Grabs the contents of the templates folder and copies them to IntermediateOutputPath directory -->
Expand Down
Loading
Loading