Repository navigation
Add connection property suffix #13471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
0c8aee4
d5bff61
e7b3c91
bc3d97e
c6bba33
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,7 +40,7 @@ When you reference Azure Kusto resources using `WithReference`, the following co | |||||
| | Property Name | Description | | ||||||
| |---------------|-------------| | ||||||
| | `Uri` | The cluster endpoint URI (inherited from parent cluster) | | ||||||
| | `Database` | The name of the database | | ||||||
| | `DatabaseName` | The name of the database | | ||||||
|
|
||||||
| Aspire exposes each property as an environment variable named `[RESOURCE]_[PROPERTY]`. For instance, the `Uri` property of a resource called `mydb` becomes `MYDB_URI`, and the `Database` property becomes `MYDB_DATABASE`. | ||||||
|
||||||
| Aspire exposes each property as an environment variable named `[RESOURCE]_[PROPERTY]`. For instance, the `Uri` property of a resource called `mydb` becomes `MYDB_URI`, and the `Database` property becomes `MYDB_DATABASE`. | |
| Aspire exposes each property as an environment variable named `[RESOURCE]_[PROPERTY]`. For instance, the `Uri` property of a resource called `mydb` becomes `MYDB_URI`, and the `DatabaseName` property becomes `MYDB_DATABASENAME`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,8 +90,8 @@ The GitHub Model resource exposes the following connection properties: | |
| |---------------|-------------| | ||
| | `Uri` | The GitHub Models inference endpoint URI, with the format `https://models.github.ai/inference` | | ||
| | `Key` | The API key (PAT or GitHub App token) for authentication | | ||
| | `Model` | The model identifier for inference requests, for instance `openai/gpt-4o-mini` | | ||
| | `Organization` | The organization attributed to the request (available when configured) | | ||
| | `ModelName` | The model identifier for inference requests, for instance `openai/gpt-4o-mini` | | ||
| | `OrganizationName` | The organization attributed to the request (available when configured) | | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, is this one necessary to suffix with "Name"?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was worried this could be interpreted as
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reverted |
||
|
|
||
| Aspire exposes each property as an environment variable named `[RESOURCE]_[PROPERTY]`. For instance, the `Uri` property of a resource called `chat` becomes `CHAT_URI`. | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,7 +137,7 @@ IEnumerable<KeyValuePair<string, ReferenceExpression>> IResourceWithConnectionSt | |
| if (PasswordParameter is not null) | ||
| { | ||
| yield return new("Password", ReferenceExpression.Create($"{PasswordParameter}")); | ||
| yield return new("AuthenticationDatabase", AuthenticationDatabaseReference); | ||
| yield return new("AuthenticationDatabaseName", AuthenticationDatabaseReference); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check again, I did before and just confirmed again
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So it's a database name, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think since it has more than just "Database" it feels weird to suffix with "Name".
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reverted |
||
| yield return new("AuthenticationMechanism", AuthenticationMechanismReference); | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,7 +48,7 @@ The SQL Server database resource inherits all properties from its parent `SqlSer | |
| |---------------|-------------| | ||
| | `Uri` | The connection URI in mssql:// format, with the format `mssql://{Username}:{Password}@{Host}:{Port}/{DatabaseName}` | | ||
| | `JdbcConnectionString` | JDBC connection string with database name, with the format `jdbc:sqlserver://{Host}:{Port};trustServerCertificate=true;databaseName={DatabaseName}`. User and password credentials are provided as separate `Username` and `Password` properties. | | ||
|
||
| | `Database` | The name of the database | | ||
| | `DatabaseName` | The name of the database | | ||
|
|
||
| Aspire exposes each property as an environment variable named `[RESOURCE]_[PROPERTY]`. For instance, the `Uri` property of a resource called `db1` becomes `DB1_URI`. | ||
|
|
||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.