Allow reading connection strings from config - #133
Merged
Conversation
- This allows the existing components (postgres, sql, redis) to read from config as a fallback after getting their own connection string. #120
| where T : IDistributedApplicationComponentWithEnvironment | ||
| { | ||
| return builder.WithReference(redisBuilder); | ||
| return builder.WithReference(redisBuilder, connectionName); |
Collaborator
Author
There was a problem hiding this comment.
This was a bug I introduced.
David Fowler (davidfowl)
requested review from
Eric Erhardt (eerhardt) and
Mitch Denny (mitchdenny)
October 9, 2023 05:41
Mitch Denny (mitchdenny)
approved these changes
Oct 9, 2023
Leszek Pietrzak (LeszekKalibrate)
pushed a commit
to LeszekKalibrate/aspire
that referenced
this pull request
Feb 27, 2025
* Update package version & fix node sample * Fix DatabaseContainers example * Fix AspireWithJavaScript sample * Fix VoumeMount sample * Fix eShopLite sample * Rename eShopLite sample to AspireShop * Update to latest Dapr client Fixes microsoft#133 * Update DatabaseContainers to use WithEntrypoint method * Update Metrics to use new WithBindMount method Fixes microsoft#139 * Update all package versions to latest on nuget.org --------- Co-authored-by: James Newton-King <james@newtonking.com> Co-authored-by: moljac <mcvjetko@holisticware.net>
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #120
PS: Once we do #132, this logic will only exist in a single place.