Skip to content

Remove .py files from being signed #13005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 2 commits into from
Nov 18, 2025
Merged

Remove .py files from being signed #13005

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac06952
Remove .py files from being signed
eerhardt Nov 17, 2025
511a1ee
PR feedback
eerhardt Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

<!-- add missing entry for .msi, this can be removed once aspire uses arcade 10.0 -->
<FileExtensionSignInfo Include=".msi" CertificateName="MicrosoftDotNet500" Condition="!@(FileExtensionSignInfo->AnyHaveMetadataValue('Identity', '.msi'))" />

<!-- Remove .py files from being signed. See https://github.com/dotnet/aspire/issues/13004 -->
<FileExtensionSignInfo Remove=".ps1;.psd1;.psm1;.psc1;.py" />

@captainsafia captainsafia Nov 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to remove then re-include the non-.py file extensions?

@eerhardt eerhardt Nov 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In MSBuild you can't change an "Include" on an Item as that's it's ID. In order to modify the "Include", you need to remove the whole Item, and then readd it with the updated value.

@joperezr joperezr Nov 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'm a bit worried about this here as we would be potentially exposed to any change of this list in a future arcade update. I wonder if with a bit more code but we could just instead calculate on the fly what the Include value is based on searching for .py, and then adding it back but replacing the .py with empty string would work?

@joperezr joperezr Nov 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you want me to work on the above

@eerhardt eerhardt Nov 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more maintainable solution would be for us to get arcade updated to support this scenario. Similar to Do not sign .js files by default (dotnet/arcade#15760).

cc @ellahathaway

@eerhardt eerhardt Nov 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened Add support to disable signing python files (dotnet/arcade#16319) for this request.

@davidfowl davidfowl Nov 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the SLA for things like this plus us taking a new arcade version (that we frequently revert?)

@radical radical Nov 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In MSBuild you can't change an "Include" on an Item as that's it's ID. In order to modify the "Include", you need to remove the whole Item, and then readd it with the updated value.

Are you sure about that? AFAIU, with the ; the items will get split up, and they will become individual items. What do you get if you print the items with %(Identity)?

@eerhardt eerhardt Nov 18, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @radical. I tested it in an isolated csproj:

    <ItemGroup>
        <FileExtensionSignInfo Include=".ps1;.psd1;.psm1;.psc1;.py" Foo="bar" />
        <FileExtensionSignInfo Remove=".py" />
    </ItemGroup>

    <Target Name="PrintInfo" BeforeTargets="Build">
      <Message Importance="High" Text="FileExtensionSignInfo items:" />
      <Message Importance="High" Text="  @(FileExtensionSignInfo->'%(Identity) - %(Foo)')" />
    </Target>

Produces

image

<FileExtensionSignInfo Include=".ps1;.psd1;.psm1;.psc1" CertificateName="Microsoft400" />
Comment thread
radical marked this conversation as resolved.
Outdated
</ItemGroup>

<ItemGroup>
Expand Down