[release/13.0] Support a docker build arg to specify the source image in PublishWithContainerFiles - #12738
Merged
Jose Perez Rodriguez (joperezr) merged 2 commits intoNov 6, 2025
Conversation
…ContainerFiles This allows an external system to provide the image name for the source image to copy the files from instead of always hard coding the image tag inline.
github-actions
Bot
requested a review
from Mitch Denny (mitchdenny)
as a code owner
November 6, 2025 03:07
dotnet-policy-service
Bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12738Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12738" |
Eric Erhardt (eerhardt)
added
the
Servicing-consider
David Fowler (davidfowl)
approved these changes
Nov 6, 2025
Eric Erhardt (eerhardt)
approved these changes
Nov 6, 2025
Jose Perez Rodriguez (joperezr)
added
Servicing-approved
Jose Perez Rodriguez (joperezr)
merged commit Nov 6, 2025
396ce67
into
release/13.0
296 checks passed
Jose Perez Rodriguez (joperezr)
deleted the
backport/pr-12716-to-release/13.0
branch
November 6, 2025 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12716 to release/13.0
/cc Eric Erhardt (@eerhardt)
Customer Impact
The new python starter template doesn't work with
azdbecause we don't give azd a chance to specify the referenced image tag when we build the dockerfiles when using.PublishWithContainerFiles. Adding a docker build arg allows azd to build the images the same way we do withaspire deploy.Testing
Existing automated tests. Plus tested the py-starter template still builds a docker image correctly.
Risk
A little bit of risk that we aren't building the dockerfiles correctly now that we generate an argument, but it is low.
Regression?
No