[release/13.0] Add buildOnly field to manifest schema and infrastructure - #12713
Merged
Jose Perez Rodriguez (joperezr) merged 5 commits intoNov 6, 2025
Merged
Conversation
The issue was that JavaScript apps using PublishAsDockerFile() were not setting HasEntrypoint=false on the correct annotation. The fix required setting it after WithDockerfileBuilder() since that method creates a new DockerfileBuildAnnotation that replaces the original one. Co-authored-by: vhvb1989 <24213737+vhvb1989@users.noreply.github.com>
As requested in code review, reverting changes to JavaScriptHostingExtensions.cs. The manifest publisher should describe current API behavior without modifying the APIs. Co-authored-by: vhvb1989 <24213737+vhvb1989@users.noreply.github.com>
Added three comprehensive tests for the containerFiles feature: - Single source with single destination - Single source with multiple source paths - Multiple sources with multiple destinations All tests verify that containerFiles are correctly serialized to the manifest JSON. Co-authored-by: vhvb1989 <24213737+vhvb1989@users.noreply.github.com>
github-actions
Bot
requested a review
from Mitch Denny (mitchdenny)
as a code owner
November 5, 2025 20:18
dotnet-policy-service
Bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12713Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12713" |
Eric Erhardt (eerhardt)
added
the
Servicing-consider
Eric Erhardt (eerhardt)
approved these changes
Nov 5, 2025
Member
|
Approved. Eric Erhardt (@eerhardt) can you double check with Victor Vazquez (@vhvb1989) before merging to ensure things work as expected? |
Jose Perez Rodriguez (joperezr)
added
Servicing-approved
Member
Yep, we are working together to ensure the whole thing works end-to-end. We will need 1 more change though - #12716 (which is the main PR). That will need to be ported to 13. |
Jose Perez Rodriguez (joperezr)
merged commit Nov 6, 2025
7e82de9
into
release/13.0
582 of 585 checks passed
Jose Perez Rodriguez (joperezr)
deleted the
backport/pr-12696-to-release/13.0
branch
November 6, 2025 01:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12696 to release/13.0
/cc Eric Erhardt (@eerhardt) Copilot
Customer Impact
This manifest information is needed for azd to support PublishWithContainerFiles.
Testing
Victor Vazquez (@vhvb1989) is testing it with azd now.
Risk
Low. We are only writing new information to the manifest.
Regression?
No