Skip to content

[release/13.0] don't build apphost in cli when running in extension#12631

Merged
joperezr merged 2 commits intorelease/13.0from
backport/pr-12621-to-release/13.0
Nov 3, 2025
Merged

[release/13.0] don't build apphost in cli when running in extension#12631
joperezr merged 2 commits intorelease/13.0from
backport/pr-12621-to-release/13.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2025

Backport of #12621 to release/13.0

/cc @adamint

Customer Impact

The VS Code extension is changing to always build an apphost inside of VS Code, instead of using the aspire cli. This allows the extension to have more control over how the build process is started, using a registered task as appropriate, and how build output is presented to the end user (ie, in the debug console).

Without this change, an apphost will be built twice when users launch their app.

Testing

Manual.

Risk

Low. The change only has an effect when users are running aspire run via the vs code extension

Regression?

No, as the behavior change was intentional.

@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 3, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12631

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12631"

@joperezr joperezr added the Servicing-approved Approved for servicing release label Nov 3, 2025
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localized changes, scoped to extension use, added unit tests, fixes build perf. Approved

@joperezr joperezr merged commit 406e287 into release/13.0 Nov 3, 2025
296 checks passed
@joperezr joperezr deleted the backport/pr-12621-to-release/13.0 branch November 3, 2025 21:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants