Skip to content

[release/13.0] Filter to highest package version per channel in aspire add command#12587

Closed
github-actions[bot] wants to merge 4 commits intorelease/13.0from
backport/pr-12553-to-release/13.0
Closed

[release/13.0] Filter to highest package version per channel in aspire add command#12587
github-actions[bot] wants to merge 4 commits intorelease/13.0from
backport/pr-12553-to-release/13.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2025

Backport of #12553 to release/13.0

/cc @mitchdenny @copilot

Customer Impact

This PR addresses an issue in the aspire add command where we show two versions of a package when a channel is chosen when only one should be shown. The underlying reason is that a channel is often comprised of multiple feeds (e.g. the daily feed references dotnet9 and nuget.org) and in the case of the Docker integration there is a pre-release package in both.

This update effectively filters the list so we only show the highest version across package sources.

Before:

image

After:

image

Testing

Manual validation

Risk

Low. Mostly impacts the preview PR experience (or when using a preview package)

Regression?

Copilot AI and others added 4 commits November 1, 2025 05:50
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
…vements

Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 1, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12587

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12587"

@mitchdenny mitchdenny added this to the 13.0 milestone Nov 1, 2025
@joperezr
Copy link
Member

joperezr commented Nov 3, 2025

Low risk and contained to the specific command. Marking as approved, but I also think that if we think this may impact other things we can also hold off for 13.1

@joperezr joperezr added the Servicing-approved Approved for servicing release label Nov 3, 2025
@davidfowl
Copy link
Contributor

Agree

@joperezr
Copy link
Member

joperezr commented Nov 6, 2025

@mitchdenny any final thoughts here? if we feel good about low risk of potential side effects I can go ahead and merge this.

@joperezr joperezr removed the Servicing-approved Approved for servicing release label Nov 7, 2025
@joperezr
Copy link
Member

joperezr commented Nov 7, 2025

Removing approval for now since at this point we should just wait for 13.0.1

@joperezr joperezr modified the milestones: 13.0, 13.1 Nov 13, 2025
@joperezr
Copy link
Member

@mitchdenny do we still want this one for 13.0.1?

@mitchdenny
Copy link
Member

Yep

@mitchdenny mitchdenny closed this Dec 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
@sebastienros sebastienros deleted the backport/pr-12553-to-release/13.0 branch January 15, 2026 23:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants