Remove fake passwords from ExpressionResolverTests test data#12525
Closed
Remove fake passwords from ExpressionResolverTests test data#12525
Conversation
Co-authored-by: karolz-ms <15271049+karolz-ms@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove fake passwords from test data in ExpressionResolverTests
Remove fake passwords from ExpressionResolverTests test data
Oct 30, 2025
karolz-ms
approved these changes
Oct 30, 2025
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12525Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12525" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes password information from SQL Server connection string test data. The changes eliminate the Password=xxx; parameter from six test cases to avoid exposing sensitive credential patterns in test code.
Key Changes
- Removed
Password=xxx;from SQL Server connection string test data across all scenarios (localhost, 127.0.0.1, and [::1]) - Maintains test coverage for host URL resolution in both container and non-container contexts
Contributor
|
#12521 will take care of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test data in
ExpressionResolverTests.cscontained fake passwords (Password=xxx;) that trigger credential scanning tools, though the tests validate hostname resolution, not authentication.Changes
Password=xxx;from 6InlineDataattributes onHostUrlPropertyGetsResolvedtest method (lines 156-161)The test validates that localhost/127.0.0.1/[::1] gets replaced with
aspire.dev.internalin connection strings when targeting containers. Password fields are irrelevant to this validation.Before:
After:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.