[release/9.4] Backport of 10422#10555
Merged
davidfowl merged 3 commits intorelease/9.4from Jul 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports missing changes from PR #10422 to the release/9.4 branch to fix build breaks caused by restructuring of the aspire exec command testing infrastructure. The changes include API method renames, improved interaction handling, and expanded testing capabilities.
Key Changes
- Method renames: Azure storage and data services methods renamed from
AddAzure*ClienttoAddAzure*ServiceClientpatterns - Test infrastructure updates: Enhanced interaction testing, removed E2E exec tests, added new console interaction tests
- Component API improvements: Added new queue client support, parameter handling enhancements, and container build options
Reviewed Changes
Copilot reviewed 293 out of 336 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/Aspire.Hosting.Azure.Tests/AzureResourcePreparerTests.cs |
Updated method calls from AddBlobs to AddBlobService |
tests/Aspire.Hosting.Azure.Tests/AzureKeyVaultTests.cs |
Added test for KV secret resource manifest exclusion |
tests/Aspire.Dashboard.Tests/ResourceOutgoingPeerResolverTests.cs |
Enhanced peer resolution with connection string and parameter support |
tests/Aspire.Cli.Tests/E2E/ExecTests.cs |
Removed entire E2E exec test file |
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.cs |
Added new queue service client methods and obsoleted old ones |
src/Aspire.Hosting/VersionChecking/VersionCheckService.cs |
Replaced version fetcher with package fetcher for better update checking |
Files not reviewed (5)
- src/Aspire.Cli/Resources/AddCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/ExecCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/TemplatingStrings.Designer.cs: Language not supported
- src/Aspire.Dashboard/Resources/ConsoleLogs.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)
tests/Aspire.Dashboard.Tests/ResourceOutgoingPeerResolverTests.cs:220
- [nitpick] The method name
TryResolvePeerCoresuggests this is an internal implementation detail. Consider if this should be calledTryResolvePeerNameCoreto match the original method name pattern.
return ResourceOutgoingPeerResolver.TryResolvePeerCore(resources, attributes, out peerName, out _);
src/Components/Aspire.Azure.Storage.Queues/AzureStorageQueuesSettings.cs
Show resolved
Hide resolved
src/Components/Aspire.Azure.Storage.Queues/AzureStorageQueuesSettings.cs
Show resolved
Hide resolved
tests/Aspire.Dashboard.Components.Tests/Interactions/InteractionsProviderTests.cs
Show resolved
Hide resolved
DeagleGross
approved these changes
Jul 19, 2025
davidfowl
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a backport of a missing PR to main that caused some build breaks on the release/9.4 branch because of some restructuring of the way that the
aspire execcommand was tested.See #10422 for details of the original PR.