Improve parameter resolution logging and exception handling in ParameterProcessor#10320
Merged
Improve parameter resolution logging and exception handling in ParameterProcessor#10320
Conversation
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve parameter resolution logging and exception handling in ParameterProcessor
Improve parameter resolution logging and exception handling in ParameterProcessor
Jul 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the logging behavior for parameter processing in the Aspire hosting orchestrator by reducing log noise and improving observability. The changes focus on making parameter resolution logging more informative while avoiding unnecessary exception details for expected scenarios.
- Removes exception details from warning logs when parameter values are missing (expected scenario)
- Adds informational logging when parameters are successfully resolved through user interaction
- Maintains full exception logging for unexpected errors during parameter processing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting/Orchestrator/ParameterProcessor.cs | Modified exception handling to log warnings without exception details for missing parameters and added resolution logging |
| tests/Aspire.Hosting.Tests/Orchestrator/ParameterProcessorTests.cs | Added comprehensive unit tests to validate the new logging behavior for both missing parameters and successful resolutions |
Comments suppressed due to low confidence (2)
tests/Aspire.Hosting.Tests/Orchestrator/ParameterProcessorTests.cs:324
- The test should also verify that no exception details are present in the log content to ensure the change from LogWarning(ex, message) to LogWarning(message) is properly validated.
Assert.False(logEntry.IsErrorMessage);
tests/Aspire.Hosting.Tests/Orchestrator/ParameterProcessorTests.cs:348
- The test should verify that exception details are included in the log content to ensure non-missing parameter exceptions still log with full exception information as intended.
Assert.True(logEntry.IsErrorMessage);
mitchdenny
approved these changes
Jul 11, 2025
Contributor
|
/backport to release/9.4 |
Contributor
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16220465689 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the logging behavior for parameter processing in the Aspire hosting orchestrator by implementing two key changes:
Changes Made
1. Remove exception logging for missing parameter values
ProcessParameterAsyncto log warnings without exception details when aMissingParameterValueExceptionoccursLogWarning(ex, message)toLogWarning(message)to reduce noise in logs2. Add parameter resolution logging via interaction service
Code Changes
Before:
After:
Testing
Added comprehensive unit tests to validate:
These changes improve the clarity and utility of resource parameter logs in Aspire by reducing noise from expected missing parameter scenarios while maintaining full visibility into resolution events.
Fixes #10319.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.