[docs] Document concrete Eventing.Subscribe<T> requirement - #1533
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32c349b4-907d-42e9-aad8-2f0edc267779
This was referenced Aug 18, 2026
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AppHost eventing documentation to explicitly state that Eventing.Subscribe<T>() requires a concrete event type, and that subscribing via an interface or abstract base type will throw an ArgumentException with the documented message.
Changes:
- Adds a caution aside documenting the concrete-type requirement for
Eventing.Subscribe<T>(). - Documents the thrown exception type and the exact message for
IDistributedApplicationEvent. - Points readers to concrete built-in event types (for example,
BeforeStartEvent,AfterResourcesCreatedEvent) as the correct subscription targets.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
David Pine (IEvangelist)
marked this pull request as ready for review
August 20, 2026 17:55
David Pine (IEvangelist)
requested review from
Karol Zadora-Przylecki (karolz-ms) and
Sébastien Ros (sebastienros)
August 20, 2026 17:55
Adam Ratzman (adamint)
approved these changes
Aug 20, 2026
Adam Ratzman (adamint)
left a comment
Adam Ratzman (adamint)
left a comment
Member
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eventing.Subscribe<T>()use a concrete event type.ArgumentExceptionbehavior and directs users to concrete event types such asBeforeStartEventorAfterResourcesCreatedEvent.src/frontend/src/content/docs/app-host/eventing.mdx.Related to microsoft/aspire#17094.
Target
This targets
mainbecause #1233 squash-mergedrelease/13.5intomainand the release branch was deleted. The branch was created directly from resultingmaincommit785524f8ce21b9b17029f88123411c5c53d833db.This clean main-based draft supersedes #1532, which GitHub automatically retargeted after the release branch deletion and expanded to 418 files because squash ancestry did not contain the old release head.
Validation
eventing.mdx.git diff --checkpassed.No reviewers requested yet. Auto-merge must remain off.