-
Notifications
You must be signed in to change notification settings - Fork 84
fix: normalize Aspire terminology in generated API reference data #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
David Pine (IEvangelist)
merged 5 commits into
main
from
dapine/normalize-api-doc-terminology
Aug 4, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2b4b86a
fix: normalize Aspire terminology in generated API reference data
IEvangelist d5818ab
fix: preserve commands in code comments
IEvangelist 574e03b
Merge remote-tracking branch 'upstream/main' into ievangelist-dapine-…
IEvangelist 7974645
fix: preserve nested interpolation strings
IEvangelist c8ea7be
fix: normalize comments inside interpolation expressions
IEvangelist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Normalize comments nested inside interpolation expressions
findInterpolationExpressionEndadvances past a nested comment without sending it throughnormalizeProse, and the outer scan then skips the complete interpolated literal. As a result, both of these valid inputs retain the forbidden term unchanged:I reproduced both directly against this head. Such comments are executable-code comments, not string contents, so they need normalization for
appHostCodeto satisfy the helper's contract and avoid the forbidden-words failure. Please normalize comment spans encountered during interpolation traversal while continuing to preserve nested literals, and add both cases as regression tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in c8ea7be. Comments nested inside C# interpolation and TypeScript template expressions now pass through
normalizeProse, while the surrounding literal stays byte-for-byte identical. Both of your reproductions are covered as regression cases (var value = $"{Get(/* app host */ 1)}";and the TS template equivalent), plus a case pairing an interpolation comment with a preserved nested string literal.