Add dataResidencyRegion option for sending to portal #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/appcenter/src/main/java/com/microsoft/appcenter/ingestion/models/Device.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @param dataResidencyRegion residency region code. | ||
| */ | ||
| public static void setDataResidencyRegion(@Nullable String dataResidencyRegion) { |
There was a problem hiding this comment.
Why @nullable here? Do we have any use case of AppCenter.setDataResidencyRegion(null)
There was a problem hiding this comment.
I decided to do this because of the requirement that data residency region can contain any string, including null
sdk/appcenter/src/main/java/com/microsoft/appcenter/utils/DeviceInfoHelper.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/main/java/com/microsoft/appcenter/utils/DeviceInfoHelper.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/main/java/com/microsoft/appcenter/utils/DeviceInfoHelper.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/main/java/com/microsoft/appcenter/utils/DeviceInfoHelper.java
Outdated
Show resolved
Hide resolved
…models/Device.java Co-authored-by: Dima <[email protected]>
…ceInfoHelper.java Co-authored-by: Dima <[email protected]>
…ceInfoHelper.java Co-authored-by: Dima <[email protected]>
…ceInfoHelper.java Co-authored-by: Dima <[email protected]>
…ceInfoHelper.java Co-authored-by: Dima <[email protected]>
…' into add-data-residency-region-option # Conflicts: # sdk/appcenter/src/main/java/com/microsoft/appcenter/ingestion/models/Device.java # sdk/appcenter/src/main/java/com/microsoft/appcenter/utils/DeviceInfoHelper.java
sdk/appcenter/src/main/java/com/microsoft/appcenter/ingestion/models/AbstractLog.java
Outdated
Show resolved
Hide resolved
…models/AbstractLog.java Co-authored-by: Dima <[email protected]>
…' into add-data-residency-region-option
DmitriyKirakosyan
approved these changes
Aug 23, 2023
Merged
|
@DmitriyKirakosyan @MikhailSuendukov Hi, is there any documentation for this new setting? In particular, what is the list of supported regions that can be set? |
|
Hi @EatonZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdbeen updated?Description
Add new API that allow to specify the data residency region for the current device.
Related PRs or issues
AB#102463