.NET: chore: updates additional analyzers packages - #8198
Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
There was a problem hiding this comment.
🟡 Changes recommended
CPM-disabled sample projects still explicitly reference the previous .NET and Roslynator analyzer versions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates repository-wide .NET analyzer package versions to help unblock Dependabot.
Changes:
- Updates .NET, xUnit, Moq, and Roslynator analyzers.
- Introduces Roslynator 5.0.0.
File summaries
| File | Description |
|---|---|
dotnet/Directory.Packages.props |
Updates centrally managed analyzer versions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: Findings reported
Scope: full PR (1 commit(s)): 0e6b641686e2
Model: gpt-5.6-sol-fast
Overview
This PR centrally updates six build-time analyzer packages while keeping analyzer assets private to the repository's builds. Strict analyzer execution, warnings-as-errors, and multi-target CI are strong guardrails, but they also expose a blocking compatibility issue: Moq.Analyzers 0.4.2 reports existing async mock setups as errors, preventing the unit-test project and therefore the full .NET solution from building.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 high) across 1 file. Details are attached to the affected lines below.
Affected areas: dotnet/Directory.Packages.props
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
One remaining Moq1206 diagnostic will fail the warnings-as-errors solution build.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Balanced
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall line coverage in commit b5031e4 in the Show a line coverage summary of the most covered files.
|
There was a problem hiding this comment.
MAF Automated Review — Iteration 2
Result: No findings
Scope: 3 net-new commit(s): bcd8ccd4edf2, ab82c95057b5, b5031e45474b
Model: gpt-5.6-sol-fast
Overview
This incremental update aligns the analyzer pins in the two CPM-disabled samples and replaces the remaining problematic async Moq lambdas with behavior-preserving local functions. Existing assertions cover the affected async ordering, cancellation, context restoration, and response semantics, while the analyzer and build matrices pass at the reviewed head. No Critical, High, or Medium defect remains in the supplied range.
Reviewed the supplied incremental change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Updates additional analyzers in the hope of unblocking dependabot