Skip to content

.NET: chore: updates additional analyzers packages - #8198

Merged
Vincent Biret (baywet) merged 4 commits into
mainfrom
deps/additional-analyzers
Sep 9, 2026
Merged

.NET: chore: updates additional analyzers packages#8198
Vincent Biret (baywet) merged 4 commits into
mainfrom
deps/additional-analyzers

Conversation

@baywet

Copy link
Copy Markdown
Member

Updates additional analyzers in the hope of unblocking dependabot

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Copilot AI balanced review requested due to automatic review settings September 9, 2026 15:07
@baywet Vincent Biret (baywet) self-assigned this Sep 9, 2026
@agent-framework-automation agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Sep 9, 2026
@github-actions github-actions Bot changed the title chore: updates additional analyzers packages .NET: chore: updates additional analyzers packages Sep 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

CPM-disabled sample projects still explicitly reference the previous .NET and Roslynator analyzer versions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates repository-wide .NET analyzer package versions to help unblock Dependabot.

Changes:

  • Updates .NET, xUnit, Moq, and Roslynator analyzers.
  • Introduces Roslynator 5.0.0.
File summaries
File Description
dotnet/Directory.Packages.props Updates centrally managed analyzer versions.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread dotnet/Directory.Packages.props
Comment thread dotnet/Directory.Packages.props

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: Findings reported
Scope: full PR (1 commit(s)): 0e6b641686e2
Model: gpt-5.6-sol-fast

Overview

This PR centrally updates six build-time analyzer packages while keeping analyzer assets private to the repository's builds. Strict analyzer execution, warnings-as-errors, and multi-target CI are strong guardrails, but they also expose a blocking compatibility issue: Moq.Analyzers 0.4.2 reports existing async mock setups as errors, preventing the unit-test project and therefore the full .NET solution from building.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 high) across 1 file. Details are attached to the affected lines below.

Affected areas: dotnet/Directory.Packages.props

Comment thread dotnet/Directory.Packages.props
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One remaining Moq1206 diagnostic will fail the warnings-as-errors solution build.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread dotnet/Directory.Packages.props
@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit b5031e4 in the deps/additional-anal... branch is 84%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.
File main deps/additional-anal... b5031e4 +/-
/home/runner/wo...valConverter.cs 100%
/home/runner/wo...entsProvider.cs 99%
/home/runner/wo...nticAnalyzer.cs 94%
/home/runner/wo...tClientAgent.cs 91%
/home/runner/wo...putConverter.cs 90%
/home/runner/wo...kflowBuilder.cs 90%
/home/runner/wo...kflowSession.cs 87%
/home/runner/wo...SkillsSource.cs 86%
/home/runner/wo...onExtensions.cs 81%
/home/runner/wo...ctionVisitor.cs 70%

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 2

Result: No findings
Scope: 3 net-new commit(s): bcd8ccd4edf2, ab82c95057b5, b5031e45474b
Model: gpt-5.6-sol-fast

Overview

This incremental update aligns the analyzer pins in the two CPM-disabled samples and replaces the remaining problematic async Moq lambdas with behavior-preserving local functions. Existing assertions cover the affected async ordering, cancellation, context restoration, and response semantics, while the analyzer and build matrices pass at the reviewed head. No Critical, High, or Medium defect remains in the supplied range.

Reviewed the supplied incremental change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants