Skip to content

.NET: ci: update Microsoft.CodeAnalysis.NetAnalyzers and Microsoft.VisualStudio.Threading.Analyzers versions - #8166

Merged
Vincent Biret (baywet) merged 2 commits into
mainfrom
deps/threading-analyzer
Sep 9, 2026
Merged

.NET: ci: update Microsoft.CodeAnalysis.NetAnalyzers and Microsoft.VisualStudio.Threading.Analyzers versions#8166
Vincent Biret (baywet) merged 2 commits into
mainfrom
deps/threading-analyzer

Conversation

@baywet

Copy link
Copy Markdown
Member

Updates Threading and Net Analazers because we're on outdated versions that cause a lot of false positives

@baywet Vincent Biret (baywet) self-assigned this Sep 8, 2026
Copilot AI balanced review requested due to automatic review settings September 8, 2026 19:34
@agent-framework-automation agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Sep 8, 2026
@github-actions github-actions Bot changed the title ci: update Microsoft.CodeAnalysis.NetAnalyzers and Microsoft.VisualStudio.Threading.Analyzers versions .NET: ci: update Microsoft.CodeAnalysis.NetAnalyzers and Microsoft.VisualStudio.Threading.Analyzers versions Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two CPM-disabled sample projects retain explicit references to both outdated analyzer versions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates repository-wide .NET analyzer versions to reduce false positives.

Changes:

  • Updates .NET analyzers to 10.0.400.
  • Updates threading analyzers to 18.7.23.
File summaries
File Description
dotnet/Directory.Packages.props Updates centrally managed analyzer versions.
Review details

Suppressed comments (1)

dotnet/Directory.Packages.props:168

  • This central bump does not reach the two CPM-disabled sample projects: AgentWithRAG_Step05_Neo4jGraphRAG.csproj:34 and AgentWithMemory_Step06_MemoryUsingAgentMemory.csproj:60 remove this inherited reference and still re-add version 17.14.15. They will continue using the analyzer version called out as outdated, so their explicit pins should also be updated to 18.7.23.
    <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23" />
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread dotnet/Directory.Packages.props

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): 37fc801b2231
Model: gpt-5.6-sol-fast

Overview

The PR updates two centrally managed, build-time-only analyzer packages while retaining private-assets isolation and existing analyzer enforcement in CI. Central package management and full-solution warning-as-error builds constrain compatibility risk, and the change introduces no runtime, public API, persistence, or security surface. No Critical, High, or Medium defect was established.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

@github-code-quality

github-code-quality Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit 82a23ba in the deps/threading-analy... branch is 84%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.
File main deps/threading-analy... 82a23ba +/-
/home/runner/wo...valConverter.cs 100%
/home/runner/wo...entsProvider.cs 99%
/home/runner/wo...nticAnalyzer.cs 94%
/home/runner/wo...tClientAgent.cs 91%
/home/runner/wo...putConverter.cs 90%
/home/runner/wo...kflowBuilder.cs 90%
/home/runner/wo...kflowSession.cs 87%
/home/runner/wo...SkillsSource.cs 86%
/home/runner/wo...onExtensions.cs 81%
/home/runner/wo...ctionVisitor.cs 70%

Updated September 09, 2026 12:30 UTC

@baywet
Vincent Biret (baywet) added this pull request to the merge queue Sep 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 9, 2026
@baywet
Vincent Biret (baywet) added this pull request to the merge queue Sep 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 9, 2026
…udio.Threading.Analyzers versions

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants