.NET: fix: do not forward headers on redirect - #8164
Merged
Conversation
Vincent Biret (baywet)
requested a review
from chetantoshniwal
as a code owner
September 8, 2026 18:28
Vincent Biret (baywet)
requested review from
Peter Ibekwe (peibekwe) and
Roger Barreto (rogerbarreto)
as code owners
September 8, 2026 18:28
Vincent Biret (baywet)
requested review from
SergeyMenshykh and
westey (westey-m)
as code owners
September 8, 2026 18:28
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 8, 2026 18:29 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 8, 2026 18:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
enabled auto-merge
September 8, 2026 18:29
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 8, 2026 18:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
temporarily deployed
to
integration
September 8, 2026 18:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
temporarily deployed
to
integration
September 8, 2026 18:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
agent-framework-automation
Bot
added
.NET
github-actions
Bot
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 8, 2026 18:46 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 8, 2026 18:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
had a problem deploying
to
integration
September 8, 2026 18:48 — with
GitHub Actions
Error
GitHub Actions
Error
Vincent Biret (baywet)
had a problem deploying
to
integration
September 8, 2026 18:48 — with
GitHub Actions
Error
GitHub Actions
Error
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 8, 2026 18:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
had a problem deploying
to
integration
September 8, 2026 18:50 — with
GitHub Actions
Error
GitHub Actions
Error
Vincent Biret (baywet)
had a problem deploying
to
integration
September 8, 2026 18:50 — with
GitHub Actions
Error
GitHub Actions
Error
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 8, 2026 18:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
had a problem deploying
to
integration
September 8, 2026 18:55 — with
GitHub Actions
Error
GitHub Actions
Error
Vincent Biret (baywet)
had a problem deploying
to
integration
September 9, 2026 16:35 — with
GitHub Actions
Failure
GitHub Actions
Failure
Vincent Biret (baywet)
had a problem deploying
to
integration
September 9, 2026 16:35 — with
GitHub Actions
Failure
GitHub Actions
Failure
Vincent Biret (baywet)
temporarily deployed
to
github-app-auth
September 9, 2026 16:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Vincent Biret (baywet)
had a problem deploying
to
integration
September 9, 2026 16:48 — with
GitHub Actions
Error
GitHub Actions
Error
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are well-covered by targeted unit tests and the only noted issue is a minor exception paramName clarity improvement.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/DefaultHttpRequestHandler.cs:279
- The thrown ArgumentException uses paramName "requestUri", which is an internal helper parameter and not meaningful to callers of SendAsync. Using the public-facing property name (Url) makes the exception easier to understand and act on.
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
SergeyMenshykh
approved these changes
Sep 10, 2026
westey (westey-m)
approved these changes
Sep 10, 2026
Roger Barreto (rogerbarreto)
approved these changes
Sep 10, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents forwarding requests headers to subsequent requests on location for 3XX responses and prescribed by RFC 9110