Skip to content

Python: FoundryEvals always emits arguments field for tool calls #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evan Mattson (moonbox3) merged 2 commits into from
Aug 21, 2026
Merged

Python: FoundryEvals always emits arguments field for tool calls #7734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
042676c
Python: always emit arguments field for tool calls in AgentEvalConverter
cr-sbarbouche Aug 18, 2026
1031859
Python: only default arguments to {} when None, not on falsy values
cr-sbarbouche Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/packages/core/agent_framework/_evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,8 +797,7 @@ def convert_message(message: Message) -> list[dict[str, Any]]:
"tool_call_id": c.call_id or "",
"name": c.name or "",
}
if args:
tc["arguments"] = args
tc["arguments"] = args if args else {}
Comment thread
cr-sbarbouche marked this conversation as resolved.
Outdated
content_items.append(tc)
elif c.type == "function_result":
result_val = c.result
Expand Down
17 changes: 17 additions & 0 deletions python/packages/foundry/tests/test_foundry_evals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,23 @@ def test_assistant_with_tool_call(self) -> None:
assert tc["name"] == "get_weather"
assert tc["arguments"] == {"location": "Seattle"}

def test_assistant_with_zero_argument_tool_call(self) -> None:
msg = Message(
"assistant",
[
Content.from_function_call(
call_id="call_3",
name="get_site_summary",
arguments=None,
),
],
)
result = AgentEvalConverter.convert_message(msg)
tc = result[0]["content"][0]
assert tc["type"] == "tool_call"
assert "arguments" in tc
assert tc["arguments"] == {}

def test_assistant_text_and_tool_call(self) -> None:
msg = Message(
"assistant",
Expand Down
Loading