.NET: Fix misleading workflow protocol attribute diagnostics - #7609
Merged
Conversation
Peter Ibekwe (peibekwe)
temporarily deployed
to
github-app-auth
August 10, 2026 22:39 — with
GitHub Actions
Inactive
Peter Ibekwe (peibekwe)
temporarily deployed
to
github-app-auth
August 10, 2026 22:39 — with
GitHub Actions
Inactive
Peter Ibekwe (peibekwe)
temporarily deployed
to
github-app-auth
August 10, 2026 22:39 — with
GitHub Actions
Inactive
Peter Ibekwe (peibekwe)
temporarily deployed
to
integration
August 10, 2026 22:39 — with
GitHub Actions
Inactive
Peter Ibekwe (peibekwe)
temporarily deployed
to
integration
August 10, 2026 22:39 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Adds protocol-specific diagnostics so executors using [SendsMessage] or [YieldsOutput] receive accurate guidance.
Changes:
- Adds
MAFGENWF008andMAFGENWF009. - Routes protocol-only validation through the new diagnostics.
- Documents and tests the
partialrequirement.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ExecutorRouteGeneratorTests.cs |
Adds regression coverage for protocol diagnostics. |
YieldsOutputAttribute.cs |
Documents the partial requirement. |
SendsMessageAttribute.cs |
Documents the partial requirement. |
DiagnosticDescriptors.cs |
Defines protocol-specific diagnostics. |
SemanticAnalyzer.cs |
Uses the new diagnostics for protocol-only classes. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Agent Framework Review — Iteration 1
Completed passes: 5 | Result: No high-severity findings
Scope: full PR (1 commit(s)): dec11d76b826
Review passes
- Correctness (
gpt-5.6-sol) — No issues found in this pass. - Security Reliability (
claude-opus-4.8) — No issues found in this pass. - Test Coverage (
gpt-5.6-sol) — No issues found in this pass. - Failure Modes (
claude-opus-4.8) — No issues found in this pass. - Design Approach (
claude-opus-4.8) — No issues found in this pass.
Peter Ibekwe (peibekwe)
marked this pull request as ready for review
August 10, 2026 23:08
Peter Ibekwe (peibekwe)
temporarily deployed
to
github-app-auth
August 10, 2026 23:09 — with
GitHub Actions
Inactive
Roger Barreto (rogerbarreto)
approved these changes
Aug 11, 2026
westey (westey-m)
approved these changes
Aug 11, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Protocol-only executors incorrectly receive diagnostics referring to
[MessageHandler]. This makes the intentionalpartialrequirement confusing.Description & Review Guide
Fixes #5163
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.